Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: chrome/browser/chrome_to_mobile_service.cc

Issue 10911084: Implement Invalidator::Acknowledge (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restart test + more cleanup Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_to_mobile_service.cc
diff --git a/chrome/browser/chrome_to_mobile_service.cc b/chrome/browser/chrome_to_mobile_service.cc
index 40326d0ac5d02bf720c9934e9da252b8d831626f..d8d8dec5cfe51e2cc12e1ef15b25bf273a90f7f5 100644
--- a/chrome/browser/chrome_to_mobile_service.cc
+++ b/chrome/browser/chrome_to_mobile_service.cc
@@ -431,6 +431,14 @@ void ChromeToMobileService::OnIncomingInvalidation(
DCHECK_EQ(1U, invalidation_map.count(invalidation::ObjectId(
ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
kSyncInvalidationObjectIdChromeToMobileDeviceList)));
+ // TODO(msw): Unit tests do not provide profiles; see http://crbug.com/122183
akalin 2012/10/19 13:27:16 I think it should be acked only when the device se
dcheng 2012/10/19 19:38:11 Done. Added a TODO and filed a crbug.
+ ProfileSyncService* profile_sync_service =
+ profile_ ? ProfileSyncServiceFactory::GetForProfile(profile_) : NULL;
+ if (profile_sync_service) {
+ profile_sync_service->AcknowledgeInvalidation(
+ invalidation_map.begin()->first,
+ invalidation_map.begin()->second.ack_handle);
+ }
RequestDeviceSearch();
}

Powered by Google App Engine
This is Rietveld 408576698