Implement Invalidator::Acknowledge

chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/string_number_conversions.h"
@@ skipping 111 matching lines @@
     const syncer::ObjectIdInvalidationMap& invalidation_map,
     syncer::IncomingInvalidationSource source) {
   DCHECK(thread_checker_.CalledOnValidThread());
   for (syncer::ObjectIdInvalidationMap::const_iterator it =
            invalidation_map.begin(); it != invalidation_map.end(); ++it) {
     std::string extension_id;
     int subchannel;
     if (ObjectIdToExtensionAndSubchannel(it->first,
                                          &extension_id,
                                          &subchannel)) {
       delegate_->OnMessage(extension_id, subchannel, it->second.payload);

[akalin, 2012/10/19 13:27:16]

Question: Is this synchronous?  i.e., can we ack immediately after this?

[dcheng, 2012/10/19 19:38:11]

Doing this properly is somewhat harder, as this involves a message to the
renderer and then being notified when the renderer is finished--the glue for
this does not currently exist. I do plan on improving this outside of this CL;
the current implementation is just to preserve legacy behavior.

     }
+    service_->AcknowledgeInvalidation(it->first, it->second.ack_handle);
   }
 }
 
 void PushMessagingInvalidationHandler::UpdateRegistrations() {
   syncer::ObjectIdSet ids;
   for (std::set<std::string>::const_iterator it =
        registered_extensions_.begin(); it != registered_extensions_.end();
        ++it) {
     const syncer::ObjectIdSet& object_ids = ExtensionIdToObjectIds(*it);
     ids.insert(object_ids.begin(), object_ids.end());
   }
   service_->UpdateRegisteredInvalidationIds(this, ids);
 }
 
 }  // namespace extensions