Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: sync/protocol/nigori_specifics.proto

Issue 10911073: NOT FOR COMMIT: Add DeviceInfo type and ChangeProcessor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Introduce SyncedDeviceTracker (the ChangeProcessor) Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/protocol/nigori_specifics.proto
diff --git a/sync/protocol/nigori_specifics.proto b/sync/protocol/nigori_specifics.proto
index 4f63ff4b696cef820912a04a0c987a8155cf0a7a..ee9437399bd6c65350160134d6bb8c8ba407eadd 100644
--- a/sync/protocol/nigori_specifics.proto
+++ b/sync/protocol/nigori_specifics.proto
@@ -27,24 +27,6 @@ message NigoriKeyBag {
repeated NigoriKey key = 2;
}
-// Information about a device that is running a sync-enabled Chrome browser.
-// We are mapping the unique per-device cache guid to more specific information
-// about the device.
-message DeviceInformation {
- optional string cache_guid = 1;
-
- // The name of the device is dependent on the OS running the Chrome instance.
- // On a Chromebook this is "Chromebook", on Linux the distribution name, on
- // Mac OSX the hadware model name and on Windows the computer name.
- optional string name = 2;
-
- // The platform of the device (ChromeOS, Linux, Mac, or Windows).
- optional string platform = 3;
-
- // The Chrome version of the sync-enabled Chrome browser.
- optional string chrome_version = 4;
-}
-
// Properties of nigori sync object.
message NigoriSpecifics {
optional EncryptedData encrypted = 1;
@@ -90,7 +72,8 @@ message NigoriSpecifics {
// User device information. Contains information about each device that has a
// sync-enabled Chrome browser connected to the user account.
- repeated DeviceInformation device_information = 28;
+ // This has been moved to the PerDeviceSpecific message.
Nicolas Zea 2012/09/13 00:45:55 PerDeviceSpecifics -> DeviceInfoSpecifics?
rlarocque 2012/09/14 01:03:07 Done.
+ // repeated DeviceInformation device_information = 28;
Raz Mathias 2012/09/13 16:07:01 Please mark this field // @deprecated
rlarocque 2012/09/14 01:03:07 Is that a java annotation? What will that do?
// Enable syncing favicons as part of tab sync.
optional bool sync_tab_favicons = 29;

Powered by Google App Engine
This is Rietveld 408576698