NOT FOR COMMIT: Add DeviceInfo type and ChangeProcessor

sync/protocol/device_info_specifics.proto

Index: sync/protocol/device_info_specifics.proto
diff --git a/sync/protocol/device_info_specifics.proto b/sync/protocol/device_info_specifics.proto
new file mode 100644
index 0000000000000000000000000000000000000000..1c55e5921aa9cd62f3de9146bd731ea46faa8b23
--- /dev/null
+++ b/sync/protocol/device_info_specifics.proto
@@ -0,0 +1,33 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Sync protocol datatype extension for nigori keys.
+
+// Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
+// any fields in this file.
+
+syntax = "proto2";
+
+option optimize_for = LITE_RUNTIME;
+option retain_unknown_fields = true;
+
+package sync_pb;
+
+// Information about a device that is running a sync-enabled Chrome browser.
+// We are mapping the unique per-device cache guid to more specific information
+// about the device.
+message DeviceInfoSpecifics {

[rlarocque, 2012/09/14 01:03:07]

Feel free to question the contents of this proto.  I just copied the old version
from the Nigori node without putting much thought into it.  We may want to add
or remove members.  

+  optional string cache_guid = 1;

[Nicolas Zea, 2012/09/13 00:45:55]

comment about this field

[rlarocque, 2012/09/14 01:03:07]

Done.

+
+  // The name of the device is dependent on the OS running the Chrome instance.
+  // On a Chromebook this is "Chromebook", on Linux the distribution name, on

[Nicolas Zea, 2012/09/13 00:45:55]

I don't think it's necessarily worth enumerating all types of names, as it's
likely this will get out of date (you left out Android and ChromeBox for
instance). Mentioning that it's platform-specific is enough.

[rlarocque, 2012/09/14 01:03:07]

Done.

+  // Mac OSX the hadware model name and on Windows the computer name.
+  optional string name = 2;

[Raz Mathias, 2012/09/13 16:07:01]

Is this field for UI display or programatic use?  If for programmatic use,
please use the UserAgent.  We are getting lost/buried in client enums and
strings server-side :-)  Will it be stamped on every upgrade?  If so, then we
should talk about maybe letting the server stamp this field for you.

[rlarocque, 2012/09/14 01:03:07]

The value of this field comes from GetSessionNameSynchronously in
get_session_name.cc.  I think it's intended to be displayed in the "Other
Devices" list on the new tab page.  Some day, we might even be able to modify
it: crbug.com/124964

+
+  // The platform of the device (ChromeOS, Linux, Mac, or Windows).
+  optional string platform = 3;

[Nicolas Zea, 2012/09/13 00:45:55]

Note that we have an enum for the supported platforms in
session_specifics.proto. It might be worth doing the same here, so you don't
have to do any parsing of the platform string. WDYT?

[rlarocque, 2012/09/14 01:03:07]

That sounds reasonable.  Will do.

+

[Raz Mathias, 2012/09/13 16:07:01]

I presume nzea means the SessionHeader.DeviceType.  Yes, please do use that.

+  // The Chrome version of the sync-enabled Chrome browser.
+  optional string chrome_version = 4;

[Raz Mathias, 2012/09/13 16:07:01]

We already have functions to extract this info server-side from the UserAgent
today.  Will the server be keeping this up-to-date for you?  (we should chat
about the different version nums we have and which we use for what purposes...)

[rlarocque, 2012/09/14 01:03:07]

The client will set this.  It uses the same function that generates the version
on the "About Chromium" page.  Maybe we should just record the user agent
instead?

+}