NOT FOR COMMIT: Add DeviceInfo type and ChangeProcessor

sync/protocol/nigori_specifics.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Sync protocol datatype extension for nigori keys.
 
 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
 // any fields in this file.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 option retain_unknown_fields = true;
 
 package sync_pb;
 
 import "encryption.proto";
 
 message NigoriKey {
   optional string name = 1;
   optional bytes user_key = 2;
   optional bytes encryption_key = 3;
   optional bytes mac_key = 4;
 }
 
 message NigoriKeyBag {
   repeated NigoriKey key = 2;
 }
 
-// Information about a device that is running a sync-enabled Chrome browser.
-// We are mapping the unique per-device cache guid to more specific information
-// about the device.
-message DeviceInformation {
-  optional string cache_guid = 1;
-
-  // The name of the device is dependent on the OS running the Chrome instance.
-  // On a Chromebook this is "Chromebook", on Linux the distribution name, on
-  // Mac OSX the hadware model name and on Windows the computer name.
-  optional string name = 2;
-
-  // The platform of the device (ChromeOS, Linux, Mac, or Windows).
-  optional string platform = 3;
-
-  // The Chrome version of the sync-enabled Chrome browser.
-  optional string chrome_version = 4;
-}
-
 // Properties of nigori sync object.
 message NigoriSpecifics {
   optional EncryptedData encrypted = 1;
   // True if |encrypted| is encrypted using a passphrase
   // explicitly set by the user.
   optional bool using_explicit_passphrase = 2;
 
   // Obsolete encryption fields. These were deprecated due to legacy versions
   // that understand their usage but did not perform encryption properly.
   // optional bool deprecated_encrypt_bookmarks = 3;
@@ skipping 25 matching lines @@
 
   // If true, all current and future datatypes will be encrypted.
   optional bool encrypt_everything = 24;
 
   optional bool encrypt_extension_settings = 25;
   optional bool encrypt_app_notifications = 26;
   optional bool encrypt_app_settings = 27;
 
   // User device information. Contains information about each device that has a
   // sync-enabled Chrome browser connected to the user account.
-  repeated DeviceInformation device_information = 28;
+  // This has been moved to the PerDeviceSpecific message.

[Nicolas Zea, 2012/09/13 00:45:55]

PerDeviceSpecifics -> DeviceInfoSpecifics?

[rlarocque, 2012/09/14 01:03:07]

Done.

+  // repeated DeviceInformation device_information = 28;

[Raz Mathias, 2012/09/13 16:07:01]

Please mark this field // @deprecated

[rlarocque, 2012/09/14 01:03:07]

Is that a java annotation?  What will that do?

   
   // Enable syncing favicons as part of tab sync.
   optional bool sync_tab_favicons = 29;
 }