Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: ui/base/events/event_dispatcher.h

Issue 10908127: events: Move EventTarget into Event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/events/event_dispatcher.h
diff --git a/ui/base/events/event_dispatcher.h b/ui/base/events/event_dispatcher.h
index 67b5a4ea2c17a2303ee93796a42bc22eefbce38a..879d31980e6e7f1e3b478aa1349806695f3d55f0 100644
--- a/ui/base/events/event_dispatcher.h
+++ b/ui/base/events/event_dispatcher.h
@@ -33,10 +33,12 @@ class UI_EXPORT EventDispatcher {
if (!target || !target->CanAcceptEvents())
return ER_UNHANDLED;
+ event->set_target(target);
+
EventHandlerList list;
target->GetPreTargetHandlers(&list);
ProcessPreTargetList(&list);
- int result = DispatchEventToEventHandlers(list, target, event);
+ int result = DispatchEventToEventHandlers(list, event);
if (result & ER_CONSUMED)
return result;
@@ -46,7 +48,7 @@ class UI_EXPORT EventDispatcher {
// this layer, however it should not be processed in the next layer of
// abstraction.
if (CanDispatchToTarget(target)) {
- result |= DispatchEventToSingleHandler(target, target, event);
+ result |= DispatchEventToSingleHandler(target, event);
if (result & ER_CONSUMED)
return result;
}
@@ -57,19 +59,17 @@ class UI_EXPORT EventDispatcher {
list.clear();
target->GetPostTargetHandlers(&list);
ProcessPostTargetList(&list);
- result |= DispatchEventToEventHandlers(list, target, event);
+ result |= DispatchEventToEventHandlers(list, event);
return result;
}
private:
template<class T>
- int DispatchEventToEventHandlers(EventHandlerList& list,
- EventTarget* target,
- T* event) {
+ int DispatchEventToEventHandlers(EventHandlerList& list, T* event) {
int result = ER_UNHANDLED;
for (EventHandlerList::const_iterator it = list.begin(),
end = list.end(); it != end; ++it) {
- result |= DispatchEventToSingleHandler((*it), target, event);
+ result |= DispatchEventToSingleHandler((*it), event);
if (result & ER_CONSUMED)
return result;
}
@@ -77,37 +77,32 @@ class UI_EXPORT EventDispatcher {
}
EventResult DispatchEventToSingleHandler(EventHandler* handler,
- EventTarget* target,
ui::KeyEvent* event) {
- return handler->OnKeyEvent(target, event);
+ return handler->OnKeyEvent(event);
}
EventResult DispatchEventToSingleHandler(EventHandler* handler,
- EventTarget* target,
ui::MouseEvent* event) {
- return handler->OnMouseEvent(target, event);
+ return handler->OnMouseEvent(event);
}
EventResult DispatchEventToSingleHandler(EventHandler* handler,
- EventTarget* target,
ui::ScrollEvent* event) {
- return handler->OnScrollEvent(target, event);
+ return handler->OnScrollEvent(event);
}
EventResult DispatchEventToSingleHandler(EventHandler* handler,
- EventTarget* target,
ui::TouchEvent* event) {
// TODO(sad): This needs fixing (especially for the QUEUED_ status).
- TouchStatus status = handler->OnTouchEvent(target, event);
+ TouchStatus status = handler->OnTouchEvent(event);
return status == ui::TOUCH_STATUS_UNKNOWN ? ER_UNHANDLED :
status == ui::TOUCH_STATUS_QUEUED_END ? ER_CONSUMED :
ER_HANDLED;
}
EventResult DispatchEventToSingleHandler(EventHandler* handler,
- EventTarget* target,
ui::GestureEvent* event) {
- return handler->OnGestureEvent(target, event);
+ return handler->OnGestureEvent(event);
}
DISALLOW_COPY_AND_ASSIGN(EventDispatcher);

Powered by Google App Engine
This is Rietveld 408576698