events: Move EventTarget into Event.

events: Move EventTarget into Event.

More notable changes:
 * Event::EventTarget is set from EventDispatcher::ProcessEvent
   (and in RootWindow for touch-events)

 * Remove the existing aura::WindowDelegate::OnXXXEvent interface,
   and update the implementations to override the EventHandler
   interface instead. Return ER_HANDLED when previously returning
   true (and ER_UNHANDLED for false).

 * Kept the stub implementation for OnScrollEvent in WindowDelegate
   (we may end up not needing OnScrollEvent after all).

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155293

[Ben Goodger (Google), 2012-09-06 21:39:15]

http://codereview.chromium.org/10908127/diff/35/ui/aura/window_delegate.cc
File ui/aura/window_delegate.cc (right):

http://codereview.chromium.org/10908127/diff/35/ui/aura/window_delegate.cc#ne...
ui/aura/window_delegate.cc:9: #if 0
que?

http://codereview.chromium.org/10908127/diff/35/ui/base/events/event.h
File ui/base/events/event.h (right):

http://codereview.chromium.org/10908127/diff/35/ui/base/events/event.h#newcode52
ui/base/events/event.h:52: void set_target(EventTarget* target) { target_ =
target; }
not sure set_target should be public... seems dangerous as someone could
re-target an event mid-flight. private and friend EventDispatcher?

[sadrul, 2012-09-06 21:44:59]

http://codereview.chromium.org/10908127/diff/35/ui/aura/window_delegate.cc
File ui/aura/window_delegate.cc (right):

http://codereview.chromium.org/10908127/diff/35/ui/aura/window_delegate.cc#ne...
ui/aura/window_delegate.cc:9: #if 0
On 2012/09/06 21:39:15, Ben Goodger (Google) wrote:
> que?

Meant to remove the block. Done :)

http://codereview.chromium.org/10908127/diff/35/ui/base/events/event.h
File ui/base/events/event.h (right):

http://codereview.chromium.org/10908127/diff/35/ui/base/events/event.h#newcode52
ui/base/events/event.h:52: void set_target(EventTarget* target) { target_ =
target; }
On 2012/09/06 21:39:15, Ben Goodger (Google) wrote:
> not sure set_target should be public... seems dangerous as someone could
> re-target an event mid-flight. private and friend EventDispatcher?

aura::RootWindow also needs to set the target for dispatching touch-events. Make
aura::RootWindow a friend too?

Does it make sense to expose this through a Event::DispatcherApi instead? (like
TestApi)

[Ben Goodger (Google), 2012-09-06 22:01:57]

yeah sg.


On Thu, Sep 6, 2012 at 2:44 PM, <sadrul@chromium.org> wrote:

>
> http://codereview.chromium.**org/10908127/diff/35/ui/aura/**
>
window_delegate.cc<http://codereview.chromium.org/10908127/diff/35/ui/aura/window_delegate.cc>
> File ui/aura/window_delegate.cc (right):
>
> http://codereview.chromium.**org/10908127/diff/35/ui/aura/**
>
window_delegate.cc#newcode9<http://codereview.chromium.org/10908127/diff/35/ui/aura/window_delegate.cc#newcode9>
> ui/aura/window_delegate.cc:9: #if 0
> On 2012/09/06 21:39:15, Ben Goodger (Google) wrote:
>
>> que?
>>
>
> Meant to remove the block. Done :)
>
>
>
http://codereview.chromium.**org/10908127/diff/35/ui/base/**events/event.h<ht...
> File ui/base/events/event.h (right):
>
> http://codereview.chromium.**org/10908127/diff/35/ui/base/**
>
events/event.h#newcode52<http://codereview.chromium.org/10908127/diff/35/ui/base/events/event.h#newcode52>
> ui/base/events/event.h:52: void set_target(EventTarget* target) {
> target_ = target; }
> On 2012/09/06 21:39:15, Ben Goodger (Google) wrote:
>
>> not sure set_target should be public... seems dangerous as someone
>>
> could
>
>> re-target an event mid-flight. private and friend EventDispatcher?
>>
>
> aura::RootWindow also needs to set the target for dispatching
> touch-events. Make aura::RootWindow a friend too?
>
> Does it make sense to expose this through a Event::DispatcherApi
> instead? (like TestApi)
>
>
http://codereview.chromium.**org/10908127/<http://codereview.chromium.org/109...
>

[sadrul, 2012-09-06 22:08:33]

On 2012/09/06 22:01:57, Ben Goodger (Google) wrote:
> yeah sg.

Done.

[Ben Goodger (Google), 2012-09-06 22:19:56]

lgtm

http://codereview.chromium.org/10908127/diff/8003/ui/base/events/event.h
File ui/base/events/event.h (right):

http://codereview.chromium.org/10908127/diff/8003/ui/base/events/event.h#newc...
ui/base/events/event.h:39: };
disallow_copy..

[sadrul, 2012-09-06 23:04:46]

http://codereview.chromium.org/10908127/diff/8003/ui/base/events/event.h
File ui/base/events/event.h (right):

http://codereview.chromium.org/10908127/diff/8003/ui/base/events/event.h#newc...
ui/base/events/event.h:39: };
On 2012/09/06 22:19:57, Ben Goodger (Google) wrote:
> disallow_copy..

Done.