Issue 10905166: gpu: Fix more clang warnings about missing virtual and OVERRIDE annotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905166: gpu: Fix more clang warnings about missing virtual and OVERRIDE annotations. (Closed)

Created:
8 years, 3 months ago by tfarina

Modified:
8 years, 3 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gpu: Fix more clang warnings about missing virtual and OVERRIDE annotations. BUG=115047 TBR=apatrick@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155581

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -33 lines)			Patch
	M	gpu/command_buffer/client/share_group.cc	View		5 chunks	+10 lines, -10 lines	1 comment	Download
	M	gpu/command_buffer/service/framebuffer_manager.cc	View		4 chunks	+25 lines, -23 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

TBRing... http://codereview.chromium.org/10905166/diff/1/gpu/command_buffer/client/share_group.cc File gpu/command_buffer/client/share_group.cc (right): http://codereview.chromium.org/10905166/diff/1/gpu/command_buffer/client/share_group.cc#newcode5 gpu/command_buffer/client/share_group.cc:5: #include "../client/atomicops.h" ouch, this should use full/absolute path, ...

8 years, 3 months ago (2012-09-08 02:41:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10905166/1

8 years, 3 months ago (2012-09-08 02:44:01 UTC) #2

lgtm

Expand Messages | Collapse Messages