gpu: Fix more clang warnings about missing virtual and OVERRIDE annotations.

gpu/command_buffer/client/share_group.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "../client/atomicops.h"

[tfarina, 2012/09/08 02:41:46]

ouch, this should use full/absolute path, no??

 #include "../client/share_group.h"
 #include "../client/gles2_implementation.h"
 #include "../client/program_info_manager.h"
 #include "../common/id_allocator.h"
 #include "../common/logging.h"
 
 namespace gpu {
 namespace gles2 {
 
 COMPILE_ASSERT(gpu::kInvalidResource == 0,
                INVALID_RESOURCE_NOT_0_AS_GL_EXPECTS);
 
 // The standard id handler.
 class IdHandler : public IdHandlerInterface {
  public:
   IdHandler() { }
   virtual ~IdHandler() { }
 
   // Overridden from IdHandlerInterface.
-  virtual void Destroy(GLES2Implementation* /* gl_impl */) {
+  virtual void Destroy(GLES2Implementation* /* gl_impl */) OVERRIDE {
   }
 
   // Overridden from IdHandlerInterface.
   virtual void MakeIds(
       GLES2Implementation* /* gl_impl */,
-      GLuint id_offset, GLsizei n, GLuint* ids) {
+      GLuint id_offset, GLsizei n, GLuint* ids) OVERRIDE {
     if (id_offset == 0) {
       for (GLsizei ii = 0; ii < n; ++ii) {
         ids[ii] = id_allocator_.AllocateID();
       }
     } else {
       for (GLsizei ii = 0; ii < n; ++ii) {
         ids[ii] = id_allocator_.AllocateIDAtOrAbove(id_offset);
         id_offset = ids[ii] + 1;
       }
     }
   }
 
   // Overridden from IdHandlerInterface.
   virtual bool FreeIds(
       GLES2Implementation* gl_impl,
-      GLsizei n, const GLuint* ids, DeleteFn delete_fn) {
+      GLsizei n, const GLuint* ids, DeleteFn delete_fn) OVERRIDE {
     for (GLsizei ii = 0; ii < n; ++ii) {
       id_allocator_.FreeID(ids[ii]);
     }
     (gl_impl->*delete_fn)(n, ids);
     // We need to ensure that the delete call is evaluated on the service side
     // before any other contexts issue commands using these client ids.
     gl_impl->helper()->CommandBufferHelper::Flush();
     return true;
   }
 
   // Overridden from IdHandlerInterface.
-  virtual bool MarkAsUsedForBind(GLuint id) {
+  virtual bool MarkAsUsedForBind(GLuint id) OVERRIDE {
     return id == 0 ? true : id_allocator_.MarkAsUsed(id);
   }
  protected:
   IdAllocator id_allocator_;
 };
 
 // An id handler that require Gen before Bind.
 class StrictIdHandler : public IdHandler {
  public:
   StrictIdHandler() { }
   virtual ~StrictIdHandler() { }
 
   // Overridden from IdHandler.
   virtual bool MarkAsUsedForBind(GLuint id) {
     GPU_DCHECK(id == 0 || id_allocator_.InUse(id));
     return IdHandler::MarkAsUsedForBind(id);
   }
 };
 
 // An id handler for ids that are never reused.
 class NonReusedIdHandler : public IdHandlerInterface {
  public:
-  NonReusedIdHandler() : last_id_(0) { }
-  virtual ~NonReusedIdHandler() { }
+  NonReusedIdHandler() : last_id_(0) {}
+  virtual ~NonReusedIdHandler() {}
 
   // Overridden from IdHandlerInterface.
-  virtual void Destroy(GLES2Implementation* /* gl_impl */) {
+  virtual void Destroy(GLES2Implementation* /* gl_impl */) OVERRIDE {
   }
 
   // Overridden from IdHandlerInterface.
   virtual void MakeIds(
       GLES2Implementation* /* gl_impl */,
-      GLuint id_offset, GLsizei n, GLuint* ids) {
+      GLuint id_offset, GLsizei n, GLuint* ids) OVERRIDE {
     for (GLsizei ii = 0; ii < n; ++ii) {
       ids[ii] = ++last_id_ + id_offset;
     }
   }
 
   // Overridden from IdHandlerInterface.
   virtual bool FreeIds(
       GLES2Implementation* gl_impl,
-      GLsizei n, const GLuint* ids, DeleteFn delete_fn) {
+      GLsizei n, const GLuint* ids, DeleteFn delete_fn) OVERRIDE {
     // Ids are never freed.
     (gl_impl->*delete_fn)(n, ids);
     return true;
   }
 
   // Overridden from IdHandlerInterface.
-  virtual bool MarkAsUsedForBind(GLuint /* id */) {
+  virtual bool MarkAsUsedForBind(GLuint /* id */) OVERRIDE {
     // This is only used for Shaders and Programs which have no bind.
     return false;
   }
 
  private:
   GLuint last_id_;
 };
 
 // An id handler for shared ids.
 class SharedIdHandler : public IdHandlerInterface {
@@ skipping 113 matching lines @@
 
 ShareGroup::~ShareGroup() {
   for (int i = 0; i < id_namespaces::kNumIdNamespaces; ++i) {
     id_handlers_[i]->Destroy(gles2_);
     id_handlers_[i].reset();
   }
 }
 
 }  // namespace gles2
 }  // namespace gpu