Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5798)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api.cc

Issue 10871034: Make all quota-exceeding messages in the storage API explain what the failure (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_api.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api.cc b/chrome/browser/extensions/api/web_request/web_request_api.cc
index add3163d50af425b05dd7f48563cfdf616a1888e..fd3b02aa86809c383cfd80976b61f7aa2f6a3155 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api.cc
@@ -1548,7 +1548,7 @@ void ExtensionWebRequestEventRouter::ClearSignaled(uint64 request_id,
class ClearCacheQuotaHeuristic : public QuotaLimitHeuristic {
public:
ClearCacheQuotaHeuristic(const Config& config, BucketMapper* map)
- : QuotaLimitHeuristic(config, map),
+ : QuotaLimitHeuristic(config, map, "clear cache"),
Matt Perry 2012/08/23 18:30:35 This won't make sense to the extension author. Let
not at google - send to devlin 2012/08/24 04:45:04 Changed to "MAX_HANDLER_BEHAVIOR_CHANGED_CALLS_PER
callback_registered_(false),
weak_ptr_factory_(this) {}
virtual ~ClearCacheQuotaHeuristic() {}
@@ -1792,7 +1792,8 @@ void WebRequestHandlerBehaviorChanged::GetQuotaLimitHeuristics(
heuristics->push_back(heuristic);
}
-void WebRequestHandlerBehaviorChanged::OnQuotaExceeded() {
+void WebRequestHandlerBehaviorChanged::OnQuotaExceeded(
+ const std::string& violation_error) {
// Post warning message.
std::set<std::string> extension_ids;
extension_ids.insert(extension_id());

Powered by Google App Engine
This is Rietveld 408576698