Make all quota-exceeding messages in the storage API explain what the failure

chrome/browser/extensions/api/web_request/web_request_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/web_request/web_request_api.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/json/json_writer.h"
@@ skipping 1530 matching lines @@
 //
 // As we want to account for the number of times the cache is really cleared
 // (opposed to the number of times webRequest.handlerBehaviorChanged() is
 // called), we cannot decide whether a call of
 // webRequest.handlerBehaviorChanged() should trigger a quota violation at the
 // time it is called. Instead we only decrement the bucket counter at the time
 // when the cache is cleared (when page loads happen).
 class ClearCacheQuotaHeuristic : public QuotaLimitHeuristic {
  public:
   ClearCacheQuotaHeuristic(const Config& config, BucketMapper* map)
-      : QuotaLimitHeuristic(config, map),
+      : QuotaLimitHeuristic(config, map, "clear cache"),

[Matt Perry, 2012/08/23 18:30:35]

This won't make sense to the extension author. Let's go with
"handlerBehaviorChanged"

[not at google - send to devlin, 2012/08/24 04:45:04]

Changed to "MAX_HANDLER_BEHAVIOR_CHANGED_CALLS_PER_10_MINUTES" as kind-of
discussed, does this sound ok?

         callback_registered_(false),
         weak_ptr_factory_(this) {}
   virtual ~ClearCacheQuotaHeuristic() {}
   virtual bool Apply(Bucket* bucket,
                      const base::TimeTicks& event_time) OVERRIDE;
 
  private:
   // Callback that is triggered by the ExtensionWebRequestEventRouter on a page
   // load.
   //
@@ skipping 223 matching lines @@
     20,                               // Refill 20 tokens per interval.
     base::TimeDelta::FromMinutes(10)  // 10 minutes refill interval.
   };
   QuotaLimitHeuristic::BucketMapper* bucket_mapper =
       new QuotaLimitHeuristic::SingletonBucketMapper();
   ClearCacheQuotaHeuristic* heuristic =
       new ClearCacheQuotaHeuristic(config, bucket_mapper);
   heuristics->push_back(heuristic);
 }
 
-void WebRequestHandlerBehaviorChanged::OnQuotaExceeded() {
+void WebRequestHandlerBehaviorChanged::OnQuotaExceeded(
+    const std::string& violation_error) {
   // Post warning message.
   std::set<std::string> extension_ids;
   extension_ids.insert(extension_id());
   BrowserThread::PostTask(
       BrowserThread::UI,
       FROM_HERE,
       base::Bind(&ExtensionWarningSet::NotifyWarningsOnUI,
                  profile_id(),
                  extension_ids,
                  ExtensionWarningSet::kRepeatedCacheFlushes));
@@ skipping 26 matching lines @@
       } else if ((*it)->name().find("AdBlock") != std::string::npos) {
         adblock = true;
       } else {
         other = true;
       }
     }
   }
 
   host->Send(new ExtensionMsg_UsingWebRequestAPI(adblock, adblock_plus, other));
 }