Make all quota-exceeding messages in the storage API explain what the failure

chrome/browser/extensions/settings/settings_api.cc

Index: chrome/browser/extensions/settings/settings_api.cc
diff --git a/chrome/browser/extensions/settings/settings_api.cc b/chrome/browser/extensions/settings/settings_api.cc
index 7cf459a822d7d24245b49a31570fccce1fcbe847..d808f19691ceebbeaa10b5b146f754e3a6f58b79 100644
--- a/chrome/browser/extensions/settings/settings_api.cc
+++ b/chrome/browser/extensions/settings/settings_api.cc
@@ -154,7 +154,9 @@ void GetModificationQuotaLimitHeuristics(QuotaLimitHeuristics* heuristics) {
   };
   heuristics->push_back(
       new ExtensionsQuotaService::TimedLimit(
-          longLimitConfig, new QuotaLimitHeuristic::SingletonBucketMapper()));
+          longLimitConfig,
+          new QuotaLimitHeuristic::SingletonBucketMapper(),
+          "MAX_WRITE_OPERATIONS_PER_HOUR"));

[Matt Perry, 2012/08/23 18:30:35]

Let's use a consistent naming scheme for these errors. The bookmarks and
webRequest APIs use "multi word phrases" while this uses "ALL_CAPS_CONSTANTS". I
slightly prefer the former.

[not at google - send to devlin, 2012/08/23 23:46:41]

I also prefer to read the multi-word phrases; however, I did it like this here
because these constants are actually named like this in the API schema
(api::storage::sync::MAX_WRITE_OPERATIONS_PER_MINUTE, thank you
json-schema-compiler). And I also like that if developers search for that string
in the docs it'll come up like that.

Consistency is king, though... and ideally all APIs that use these constants
should have them defined in the JSON; that helps developers understand the
errors... then we can give them their symbolic names?

Do you agree? If so, what is the best course of action... do that in a
follow-up, or do that now (happy either way)? Or just change these to be
phrases?

[Matt Perry, 2012/08/23 23:55:06]

That makes sense. Use SYMBOLIC_NAMES everywhere now, and add the definitions to
the schema files (can be done in a followup).

[not at google - send to devlin, 2012/08/24 04:45:04]

I've done it in this change because I was unsure what to call them, and putting
them in the documentation now will help with that.

So, done. Could you sanity check the names?

 
   // A max of 10 operations per minute, sustained over 10 minutes.
   QuotaLimitHeuristic::Config shortLimitConfig = {
@@ -166,7 +168,8 @@ void GetModificationQuotaLimitHeuristics(QuotaLimitHeuristics* heuristics) {
       new ExtensionsQuotaService::SustainedLimit(
           base::TimeDelta::FromMinutes(10),
           shortLimitConfig,
-          new QuotaLimitHeuristic::SingletonBucketMapper()));
+          new QuotaLimitHeuristic::SingletonBucketMapper(),
+          "MAX_SUSTAINED_WRITE_OPERATIONS_PER_MINUTE"));
 };
 
 }  // namespace