Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10870060: Removed calls to URLRequest::URLRequest in favor of URLRequestContext::CreateRequest (Closed)

Created:
8 years, 4 months ago by shalev
Modified:
5 years, 4 months ago
CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, oshima+watch_chromium.org, tfarina, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, pam+watch_chromium.org, rdsmith+dwatch_chromium.org, stuartmorgan+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed nits #

Patch Set 3 : Fixed nits #

Patch Set 4 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -79 lines) Patch
M chrome/browser/net/chrome_fraudulent_certificate_reporter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/connection_tester.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/net/http_pipelining_compatibility_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/plugin_installer.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/debugger/devtools_http_handler_impl.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_impl.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M net/ocsp/nss_ocsp.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_update_job.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M webkit/appcache/appcache_url_request_job_unittest.cc View 1 4 chunks +8 lines, -16 lines 0 comments Download
M webkit/blob/blob_url_request_job_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webkit/chromeos/fileapi/remote_file_system_operation.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/fileapi/file_writer_delegate_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M webkit/fileapi/local_file_system_operation.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
shalev
Hi Will and Matt, Please take a look. Shalev
8 years, 4 months ago (2012-08-24 07:22:37 UTC) #1
erikwright (departed)
LGTM. Is this all of them? Once you have Will or Matt's LGTM, feel free ...
8 years, 4 months ago (2012-08-24 08:08:54 UTC) #2
mmenke
LGTM http://codereview.chromium.org/10870060/diff/1/content/browser/renderer_host/resource_dispatcher_host_impl.cc File content/browser/renderer_host/resource_dispatcher_host_impl.cc (right): http://codereview.chromium.org/10870060/diff/1/content/browser/renderer_host/resource_dispatcher_host_impl.cc#newcode939 content/browser/renderer_host/resource_dispatcher_host_impl.cc:939: request_data.url, NULL)); optional nit: May want to separate ...
8 years, 4 months ago (2012-08-24 14:40:10 UTC) #3
shalev
http://codereview.chromium.org/10870060/diff/1/content/browser/renderer_host/resource_dispatcher_host_impl.cc File content/browser/renderer_host/resource_dispatcher_host_impl.cc (right): http://codereview.chromium.org/10870060/diff/1/content/browser/renderer_host/resource_dispatcher_host_impl.cc#newcode939 content/browser/renderer_host/resource_dispatcher_host_impl.cc:939: request_data.url, NULL)); On 2012/08/24 14:40:11, Matt Menke wrote: > ...
8 years, 4 months ago (2012-08-24 19:07:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shalev@chromium.org/10870060/5004
8 years, 4 months ago (2012-08-24 22:13:47 UTC) #5
commit-bot: I haz the power
Try job failure for 10870060-5004 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-24 23:46:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shalev@chromium.org/10870060/5004
8 years, 3 months ago (2012-08-28 18:21:53 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-08-28 18:22:05 UTC) #8 
Failed to apply patch for net/ocsp/nss_ocsp.cc:
While running patch -p1 --forward --force;
patching file net/ocsp/nss_ocsp.cc
Hunk #1 FAILED at 367.
1 out of 1 hunk FAILED -- saving rejects to file net/ocsp/nss_ocsp.cc.rej

Powered by Google App Engine
This is Rietveld 408576698