Added URLRequestContext::CreateRequest

Added URLRequestContext::CreateRequest which can be used to create URLRequests

BUG=142945
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153302

[shalev, 2012-08-24 07:22:02]

Hi Will and Matt,

Please take a look.

Shalev

[erikwright (departed), 2012-08-24 08:02:55]

LGTM minus the two comments.

http://codereview.chromium.org/10873056/diff/1/net/test/spawner_communicator.cc
File net/test/spawner_communicator.cc (right):

http://codereview.chromium.org/10873056/diff/1/net/test/spawner_communicator....
net/test/spawner_communicator.cc:172: cur_request_.reset(context_.CreateRequest(
probably want context_->, not '.'

http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request_co...
File net/url_request/url_request_context.h (right):

http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request_co...
net/url_request/url_request_context.h:25: #include
"net/url_request/url_request.h"
forward decl instead.

[mmenke, 2012-08-24 14:31:59]

http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request.cc
File net/url_request/url_request.cc (right):

http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request.cc...
net/url_request/url_request.cc:456: DCHECK(network_delegate_ ==
context_->network_delegate());
nit:  DCHECK_EQ

http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request.cc...
net/url_request/url_request.cc:483: DCHECK(network_delegate_ ==
context_->network_delegate());
DCHECK_EQ

[mmenke, 2012-08-24 14:32:09]

Oh, and LGTM

[shalev, 2012-08-24 15:36:40]

http://codereview.chromium.org/10873056/diff/1/net/test/spawner_communicator.cc
File net/test/spawner_communicator.cc (right):

http://codereview.chromium.org/10873056/diff/1/net/test/spawner_communicator....
net/test/spawner_communicator.cc:172: cur_request_.reset(context_.CreateRequest(
On 2012/08/24 08:02:55, erikwright wrote:
> probably want context_->, not '.'

Done.

http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request.cc
File net/url_request/url_request.cc (right):

http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request.cc...
net/url_request/url_request.cc:456: DCHECK(network_delegate_ ==
context_->network_delegate());
On 2012/08/24 14:32:00, Matt Menke wrote:
> nit:  DCHECK_EQ

Done.

http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request.cc...
net/url_request/url_request.cc:483: DCHECK(network_delegate_ ==
context_->network_delegate());
On 2012/08/24 14:32:00, Matt Menke wrote:
> DCHECK_EQ

Done.

http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request_co...
File net/url_request/url_request_context.h (right):

http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request_co...
net/url_request/url_request_context.h:25: #include
"net/url_request/url_request.h"
On 2012/08/24 08:02:55, erikwright wrote:
> forward decl instead.

How do I forward declare URLRequest::Delegate?

[erikwright (departed), 2012-08-24 15:39:03]

On 2012/08/24 15:36:40, shalev wrote:
>
http://codereview.chromium.org/10873056/diff/1/net/test/spawner_communicator.cc
> File net/test/spawner_communicator.cc (right):
> 
>
http://codereview.chromium.org/10873056/diff/1/net/test/spawner_communicator....
> net/test/spawner_communicator.cc:172:
cur_request_.reset(context_.CreateRequest(
> On 2012/08/24 08:02:55, erikwright wrote:
> > probably want context_->, not '.'
> 
> Done.
> 
> http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request.cc
> File net/url_request/url_request.cc (right):
> 
>
http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request.cc...
> net/url_request/url_request.cc:456: DCHECK(network_delegate_ ==
> context_->network_delegate());
> On 2012/08/24 14:32:00, Matt Menke wrote:
> > nit:  DCHECK_EQ
> 
> Done.
> 
>
http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request.cc...
> net/url_request/url_request.cc:483: DCHECK(network_delegate_ ==
> context_->network_delegate());
> On 2012/08/24 14:32:00, Matt Menke wrote:
> > DCHECK_EQ
> 
> Done.
> 
>
http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request_co...
> File net/url_request/url_request_context.h (right):
> 
>
http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request_co...
> net/url_request/url_request_context.h:25: #include
> "net/url_request/url_request.h"
> On 2012/08/24 08:02:55, erikwright wrote:
> > forward decl instead.
> 
> How do I forward declare URLRequest::Delegate?

Oh, you can't. Didn't see that. Nevermind.

[mmenke, 2012-08-24 15:39:09]

http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request_co...
File net/url_request/url_request_context.h (right):

http://codereview.chromium.org/10873056/diff/1/net/url_request/url_request_co...
net/url_request/url_request_context.h:25: #include
"net/url_request/url_request.h"
On 2012/08/24 15:36:40, shalev wrote:
> On 2012/08/24 08:02:55, erikwright wrote:
> > forward decl instead.
> 
> How do I forward declare URLRequest::Delegate?

You can't forward declare inner classes, unfortunately.

[commit-bot: I haz the power, 2012-08-24 19:22:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shalev@chromium.org/10873056/4003

[commit-bot: I haz the power, 2012-08-24 21:49:23]

Change committed as 153302