chrome/browser/extensions/sandboxed_unpacker_unittest.cc - Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/sandboxed_unpacker_unittest.cc

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc ('K') | « chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc ('k') | chrome/browser/policy/app_pack_updater.cc » ('j') | chrome/browser/policy/app_pack_updater.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/sandboxed_unpacker_unittest.cc

diff --git a/chrome/browser/extensions/sandboxed_unpacker_unittest.cc b/chrome/browser/extensions/sandboxed_unpacker_unittest.cc

index 3be80b28074191e34318cb1178b672fe096dea82..0b7cfe449d1fbbf18bd0776752d6d4926e7bdafd 100644

--- a/chrome/browser/extensions/sandboxed_unpacker_unittest.cc

+++ b/chrome/browser/extensions/sandboxed_unpacker_unittest.cc

@@ -135,10 +135,9 @@ class SandboxedUnpackerTest : public testing::Test {

bool TempFilesRemoved() {

// Check that temporary files were cleaned up.

- file_util::FileEnumerator::FileType files_and_dirs =

- static_cast<file_util::FileEnumerator::FileType>(

+ int files_and_dirs =

not at google - send to devlin 2012/08/06 05:04:56 should be kFilesAndDirs

Haruki Sato 2012/08/06 23:22:18 Good catch. I will follow up with another CL.

file_util::FileEnumerator::DIRECTORIES |

- file_util::FileEnumerator::FILES);

+ file_util::FileEnumerator::FILES;

jar (doing other things) 2012/08/06 18:27:02 nit: push either line 140 or 139 onto the end of 1

Haruki Sato 2012/08/06 23:22:18 Done.

file_util::FileEnumerator temp_iterator(

temp_path_,