Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc
diff --git a/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc b/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc
index c069ebb2b976100f9fc2a441ffee8e5ea046e67a..b10064e689d10c12aa4b4f76183d0bf0a3f2c42f 100644
--- a/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc
+++ b/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc
@@ -66,10 +66,9 @@ SerialPortEnumerator::StringSet
SerialPortEnumerator::GenerateValidSerialPortNames() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
const FilePath DEV_ROOT("/dev");
- const file_util::FileEnumerator::FileType FILES_AND_SYM_LINKS =
- static_cast<file_util::FileEnumerator::FileType>(
- file_util::FileEnumerator::FILES |
- file_util::FileEnumerator::SHOW_SYM_LINKS);
+ const int FILES_AND_SYM_LINKS =
not at google - send to devlin 2012/08/06 05:04:56 should be kFilesAndSymLinks
Haruki Sato 2012/08/06 23:22:18 I agree. Can I do that in another CL?
not at google - send to devlin 2012/08/06 23:28:18 I guess, though, easy enough to do now if at all.
jar (doing other things) 2012/08/07 01:47:43 +1 The name is all in this file... so it should b
Haruki Sato 2012/08/07 02:29:17 Done. Could you double check?
+ file_util::FileEnumerator::FILES |
+ file_util::FileEnumerator::SHOW_SYM_LINKS;
StringSet valid_patterns = GenerateValidPatterns();
StringSet name_set;

Powered by Google App Engine
This is Rietveld 408576698