chrome/browser/policy/app_pack_updater.cc - Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/app_pack_updater.cc

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/sandboxed_unpacker_unittest.cc ('K') | « chrome/browser/extensions/sandboxed_unpacker_unittest.cc ('k') | chrome/browser/ui/webui/chromeos/drive_internals_ui.cc » ('j') | chrome/browser/ui/webui/chromeos/drive_internals_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/app_pack_updater.cc

diff --git a/chrome/browser/policy/app_pack_updater.cc b/chrome/browser/policy/app_pack_updater.cc

index 20d5f20b9ca3ccd2c4b4c9ccbe68e7d31d61928d..38ae650971eb9cfb018fbbcedd6c7d464a978107 100644

--- a/chrome/browser/policy/app_pack_updater.cc

+++ b/chrome/browser/policy/app_pack_updater.cc

@@ -277,9 +277,9 @@ void AppPackUpdater::BlockingCheckCacheInternal(

// Enumerate all the files in the cache |dir|, including directories

// and symlinks. Each unrecognized file will be erased.

- FileEnumerator::FileType types = static_cast<FileEnumerator::FileType>(

+ int types =

FileEnumerator::FILES | FileEnumerator::DIRECTORIES |

jar (doing other things) 2012/08/06 18:27:02 nit: push one or more elements of line 281/282 ont

Haruki Sato 2012/08/06 23:22:18 Done.

- FileEnumerator::SHOW_SYM_LINKS);

+ FileEnumerator::SHOW_SYM_LINKS;

FileEnumerator enumerator(dir, false /* recursive */, types);

for (FilePath path = enumerator.Next();