chrome/browser/chromeos/login/camera_detector.cc - Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/camera_detector.cc

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/gdata/gdata_cache_metadata.cc ('K') | « chrome/browser/chromeos/gdata/gdata_cache_unittest.cc ('k') | chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc » ('j') | chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/camera_detector.cc

diff --git a/chrome/browser/chromeos/login/camera_detector.cc b/chrome/browser/chromeos/login/camera_detector.cc

index 9c4bc2760ca15061adf12a396e2198cec959c2a6..5951503289d5888c3b674cbe2b093c601f649caa 100644

--- a/chrome/browser/chromeos/login/camera_detector.cc

+++ b/chrome/browser/chromeos/login/camera_detector.cc

@@ -59,8 +59,7 @@ void CameraDetector::CheckPresence() {

FileEnumerator file_enum(

FilePath(kV4LSubsystemDir),

false, // Don't recurse.

jar (doing other things) 2012/08/06 18:27:02 nit: suggest putting line 61 onto end of line 60.

Haruki Sato 2012/08/06 23:22:18 Done.

- static_cast<FileEnumerator::FileType>(

- FileEnumerator::FILES | FileEnumerator::SHOW_SYM_LINKS));

+ (FileEnumerator::FILES | FileEnumerator::SHOW_SYM_LINKS));

jar (doing other things) 2012/08/06 18:27:02 nit: suggest romoving parens around this arg.

Haruki Sato 2012/08/06 23:22:18 Done.

for (FilePath path = file_enum.Next(); !path.empty();

path = file_enum.Next()) {

std::string v4l_capabilities;