chrome/browser/chromeos/gdata/gdata_cache_unittest.cc - Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/gdata/gdata_cache_unittest.cc

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/gdata/gdata_cache_metadata.cc ('K') | « chrome/browser/chromeos/gdata/gdata_cache_metadata.cc ('k') | chrome/browser/chromeos/login/camera_detector.cc » ('j') | chrome/browser/chromeos/login/camera_detector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/gdata/gdata_cache_unittest.cc

diff --git a/chrome/browser/chromeos/gdata/gdata_cache_unittest.cc b/chrome/browser/chromeos/gdata/gdata_cache_unittest.cc

index 31eef3851d267b924d46378fa55ad126790d68e4..947e86a2ab8a63e635a450b643f0295cb68f1a3c 100644

--- a/chrome/browser/chromeos/gdata/gdata_cache_unittest.cc

+++ b/chrome/browser/chromeos/gdata/gdata_cache_unittest.cc

@@ -375,9 +375,8 @@ class GDataCacheTest : public testing::Test {

for (size_t i = 0; i < paths_to_verify.size(); ++i) {

file_util::FileEnumerator enumerator(

paths_to_verify[i].path_to_scan.DirName(), false /* not recursive*/,

- static_cast<file_util::FileEnumerator::FileType>(

- file_util::FileEnumerator::FILES |

- file_util::FileEnumerator::SHOW_SYM_LINKS),

+ (file_util::FileEnumerator::FILES |

+ file_util::FileEnumerator::SHOW_SYM_LINKS),

paths_to_verify[i].path_to_scan.BaseName().value());

EXPECT_TRUE(enumerator.Next().empty());

}

@@ -416,9 +415,8 @@ class GDataCacheTest : public testing::Test {

const struct PathToVerify& verify = paths_to_verify[i];

file_util::FileEnumerator enumerator(

verify.path_to_scan.DirName(), false /* not recursive*/,

- static_cast<file_util::FileEnumerator::FileType>(

- file_util::FileEnumerator::FILES |

- file_util::FileEnumerator::SHOW_SYM_LINKS),

+ (file_util::FileEnumerator::FILES |

+ file_util::FileEnumerator::SHOW_SYM_LINKS),

verify.path_to_scan.BaseName().value());

size_t num_files_found = 0;

for (FilePath current = enumerator.Next(); !current.empty();