Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7137)

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 10837296: Fix a bug where the inspector would not keep event pages alive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: notification Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_popup.cc
diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc
index 2412d0fcc25a5a0027293a12edbf95dc1d7ecad0..f7305569d04e07826e2ed51c1189eb30e56f5877 100644
--- a/chrome/browser/ui/views/extensions/extension_popup.cc
+++ b/chrome/browser/ui/views/extensions/extension_popup.cc
@@ -91,12 +91,12 @@ ExtensionPopup::ExtensionPopup(
// Listen for the dev tools opening on this popup, so we can stop it going
// away when the dev tools get focus.
- registrar_.Add(this, content::NOTIFICATION_DEVTOOLS_WINDOW_OPENING,
+ registrar_.Add(this, content::NOTIFICATION_DEVTOOLS_AGENT_ATTACHED,
content::Source<Profile>(host->profile()));
// Listen for the dev tools closing, so we can close this window if it is
// being inspected and the inspector is closed.
- registrar_.Add(this, content::NOTIFICATION_DEVTOOLS_WINDOW_CLOSING,
+ registrar_.Add(this, content::NOTIFICATION_DEVTOOLS_AGENT_DETACHED,
content::Source<content::BrowserContext>(host->profile()));
}
@@ -118,7 +118,7 @@ void ExtensionPopup::Observe(int type,
if (content::Details<extensions::ExtensionHost>(host()) == details)
GetWidget()->Close();
break;
- case content::NOTIFICATION_DEVTOOLS_WINDOW_CLOSING:
+ case content::NOTIFICATION_DEVTOOLS_AGENT_DETACHED:
// Make sure it's the devtools window that inspecting our popup.
// Widget::Close posts a task, which should give the devtools window a
// chance to finish detaching from the inspected RenderViewHost.
@@ -127,7 +127,7 @@ void ExtensionPopup::Observe(int type,
GetWidget()->Close();
}
break;
- case content::NOTIFICATION_DEVTOOLS_WINDOW_OPENING:
+ case content::NOTIFICATION_DEVTOOLS_AGENT_ATTACHED:
// First check that the devtools are being opened on this popup.
if (content::Details<RenderViewHost>(host()->render_view_host()) ==
details) {

Powered by Google App Engine
This is Rietveld 408576698