Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5102)

Unified Diff: chrome/browser/debugger/devtools_window.cc

Issue 10837296: Fix a bug where the inspector would not keep event pages alive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: notification Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/debugger/devtools_window.cc
diff --git a/chrome/browser/debugger/devtools_window.cc b/chrome/browser/debugger/devtools_window.cc
index e1a282b96bb56574ab9679a322cc590866fd3fc1..74661bad51b1bec976fa2261926f213c8befc9fe 100644
--- a/chrome/browser/debugger/devtools_window.cc
+++ b/chrome/browser/debugger/devtools_window.cc
@@ -643,10 +643,11 @@ DevToolsWindow* DevToolsWindow::ToggleDevToolsWindow(
// If window is docked and visible, we hide it on toggle. If window is
// undocked, we show (activate) it.
- if (!window->is_docked() || do_open)
+ if (!window->is_docked() || do_open) {
yurys 2012/08/21 19:52:55 Revert this? As I remember style guide doesn't req
Matt Perry 2012/08/21 20:13:46 Oops, leftover change. Reverted.
window->Show(action);
- else
+ } else {
manager->UnregisterDevToolsClientHostFor(agent);
+ }
return window;
}
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_process_manager.cc » ('j') | content/browser/debugger/devtools_agent_host.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698