Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc

Issue 10837296: Fix a bug where the inspector would not keep event pages alive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: notification Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc
diff --git a/chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc b/chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc
index 119705bd6fa0d748592bc9ba48223138b91d946f..a7f5509dd7835087479f3d83662027027db5b282 100644
--- a/chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc
+++ b/chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc
@@ -63,11 +63,11 @@ ExtensionPopupGtk::ExtensionPopupGtk(Browser* browser,
registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE,
content::Source<Profile>(host->profile()));
- registrar_.Add(this, content::NOTIFICATION_DEVTOOLS_WINDOW_CLOSING,
+ registrar_.Add(this, content::NOTIFICATION_DEVTOOLS_AGENT_DETACHED,
content::Source<Profile>(host->profile()));
if (!being_inspected_) {
- registrar_.Add(this, content::NOTIFICATION_DEVTOOLS_WINDOW_OPENING,
+ registrar_.Add(this, content::NOTIFICATION_DEVTOOLS_AGENT_ATTACHED,
content::Source<Profile>(host->profile()));
}
}
@@ -101,7 +101,7 @@ void ExtensionPopupGtk::Observe(int type,
if (content::Details<extensions::ExtensionHost>(host_.get()) == details)
DestroyPopup();
break;
- case content::NOTIFICATION_DEVTOOLS_WINDOW_OPENING:
+ case content::NOTIFICATION_DEVTOOLS_AGENT_ATTACHED:
// Make sure it's the devtools window that is inspecting our popup.
if (content::Details<RenderViewHost>(host_->render_view_host()) !=
details)
@@ -113,7 +113,7 @@ void ExtensionPopupGtk::Observe(int type,
being_inspected_ = true;
break;
- case content::NOTIFICATION_DEVTOOLS_WINDOW_CLOSING:
+ case content::NOTIFICATION_DEVTOOLS_AGENT_DETACHED:
// Make sure it's the devtools window that is inspecting our popup.
if (content::Details<RenderViewHost>(host_->render_view_host()) !=
details)

Powered by Google App Engine
This is Rietveld 408576698