ChromeOS: Fix DCHECK failure after file copying in Drive folder.

ChromeOS: Fix DCHECK failure after file copying in Drive folder.

This is due to multiple callback calls in GDataFileSystem::AddUploadedFileToCache.
It should be called exactly once on every code path.

BUG=none
TEST=Manual: open Drive folder, select a file, ctrl-C and then ctrl-V.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151713

[kinaba, 2012-08-15 07:27:00]

Kochi-san, could you give a quick look?

[kochi, 2012-08-15 07:34:44]

http://codereview.chromium.org/10834328/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10834328/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:3086: params->callback.Run();
What does it make sense for after NOTREACHED()?
If it does, please comment why this makes sense, otherwise
just make it fail.

[kinaba, 2012-08-15 07:52:42]

http://codereview.chromium.org/10834328/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10834328/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:3086: params->callback.Run();
On 2012/08/15 07:34:44, Takayoshi Kochi wrote:
> What does it make sense for after NOTREACHED()?
> If it does, please comment why this makes sense, otherwise
> just make it fail.

Added comment. To be more safer, I'd like to stick to calling it,
since it is the behavior before the regression
http://codereview.chromium.org/10829277/diff/10016/chrome/browser/chromeos/gd...
and it looks the convention is adopted chromeos/gdata-wise.

[kochi, 2012-08-15 07:55:32]

lgtm

[commit-bot: I haz the power, 2012-08-15 09:13:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/10834328/7001

[achuithb, 2012-08-15 09:40:07]

lgtm. This was my mistake - thanks for fixing it.

[commit-bot: I haz the power, 2012-08-15 10:50:47]

Try job failure for 10834328-7001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-15 13:21:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/10834328/7001

[commit-bot: I haz the power, 2012-08-15 17:32:35]

Change committed as 151713