Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5456)

Unified Diff: chrome/browser/chromeos/gdata/gdata_file_system.cc

Issue 10834328: ChromeOS: Fix DCHECK failure after file copying in Drive folder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comment. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_file_system.cc
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system.cc b/chrome/browser/chromeos/gdata/gdata_file_system.cc
index 245af9b9db5c73e9df8d835a37d48a4ca8931d2b..808ac0eae55447598be6b1326170f4d4583d11cf 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system.cc
+++ b/chrome/browser/chromeos/gdata/gdata_file_system.cc
@@ -3083,8 +3083,11 @@ void GDataFileSystem::AddUploadedFileToCache(
params->callback));
} else {
NOTREACHED() << "Unexpected upload mode: " << params->upload_mode;
+ // Shouldn't reach here, so the line below should not make much sense, but
+ // since calling |callback| exactly once is our obligation, we'd better call
+ // it for not to clutter further more.
+ params->callback.Run();
}
- params->callback.Run();
}
void GDataFileSystem::Observe(int type,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698