ChromeOS: Fix DCHECK failure after file copying in Drive folder.

chrome/browser/chromeos/gdata/gdata_file_system.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_file_system.h"
 
 #include <set>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 3065 matching lines @@
                             base::Bind(&OnCacheUpdatedForAddUploadedFile,
                                        params->callback));
   } else if (params->upload_mode == UPLOAD_EXISTING_FILE) {
     // Clear the dirty bit if we have updated an existing file.
     cache_->ClearDirtyOnUIThread(params->resource_id,
                                  params->md5,
                                  base::Bind(&OnCacheUpdatedForAddUploadedFile,
                                             params->callback));
   } else {
     NOTREACHED() << "Unexpected upload mode: " << params->upload_mode;
+    params->callback.Run();

[kochi, 2012/08/15 07:34:44]

What does it make sense for after NOTREACHED()?
If it does, please comment why this makes sense, otherwise
just make it fail.

[kinaba, 2012/08/15 07:52:42]

Added comment. To be more safer, I'd like to stick to calling it,
since it is the behavior before the regression
http://codereview.chromium.org/10829277/diff/10016/chrome/browser/chromeos/gd...
and it looks the convention is adopted chromeos/gdata-wise.

   }
-  params->callback.Run();
 }
 
 void GDataFileSystem::Observe(int type,
                               const content::NotificationSource& source,
                               const content::NotificationDetails& details) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   if (type == chrome::NOTIFICATION_PREF_CHANGED) {
     PrefService* pref_service = profile_->GetPrefs();
     std::string* pref_name = content::Details<std::string>(details).ptr();
@@ skipping 353 matching lines @@
     return;
   }
 
   PlatformFileInfoProto entry_file_info;
   GDataEntry::ConvertPlatformFileInfoToProto(*file_info, &entry_file_info);
   *entry_proto->mutable_file_info() = entry_file_info;
   callback.Run(GDATA_FILE_OK, entry_proto.Pass());
 }
 
 }  // namespace gdata