Issue 10832146: Improve method names in the ThrowException test to make it less misleading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832146: Improve method names in the ThrowException test to make it less misleading. (Closed)

Created:
8 years, 4 months ago by turnidge

Modified:
8 years, 4 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Improve method names in the ThrowException test to make it less misleading. Committed: https://code.google.com/p/dart/source/detail?r=10262

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	vm/dart_api_impl_test.cc	View		2 chunks	+7 lines, -7 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

8 years, 4 months ago (2012-08-06 08:02:50 UTC) #2

LGTM, with comment.

http://codereview.chromium.org/10832146/diff/1/vm/dart_api_impl_test.cc
File vm/dart_api_impl_test.cc (right):

http://codereview.chromium.org/10832146/diff/1/vm/dart_api_impl_test.cc#newco...
vm/dart_api_impl_test.cc:3997: // Now invoke 'test' which indirectly invokes a
natve method where
native is misspelled natve.  Sentence is confusing.

// Call 'test' which calls the native function
// "ThrowException_native' (as 'thrower').
// Check that it throws an exception.

Expand Messages | Collapse Messages