Improve method names in the ThrowException test to make it less misleading.

vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/json.h"
 #include "platform/utils.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
@@ skipping 3945 matching lines @@
 
 static Dart_NativeFunction native_lookup(Dart_Handle name, int argument_count) {
   return reinterpret_cast<Dart_NativeFunction>(&ExceptionNative);
 }
 
 
 TEST_CASE(ThrowException) {
   const char* kScriptChars =
       "class ThrowException {\n"
       "  ThrowException(int i) : fld1 = i {}\n"
-      "  int method1(int i) native \"ThrowException_native\";"
-      "  int method2() {\n"
-      "     try { method1(10); } catch(var a) { return 5; } return 10;\n"
+      "  int thrower(int i) native \"ThrowException_native\";"
+      "  int test() {\n"
+      "     try { thrower(10); } catch(var a) { return 5; } return 10;\n"
       "  }\n"
       "  int fld1;\n"
       "}\n"
       "ThrowException testMain() {\n"
       "  ThrowException obj = new ThrowException(10);\n"
       "  return obj;\n"
       "}\n";
   Dart_Handle result;
   Isolate* isolate = Isolate::Current();
   EXPECT(isolate != NULL);
   ApiState* state = isolate->api_state();
   EXPECT(state != NULL);
   intptr_t size = state->ZoneSizeInBytes();
   Dart_EnterScope();  // Start a Dart API scope for invoking API functions.
 
   // Load up a test script which extends the native wrapper class.
   Dart_Handle lib = TestCase::LoadTestScript(
       kScriptChars,
       reinterpret_cast<Dart_NativeEntryResolver>(native_lookup));
 
   // Invoke a function which returns an object of type ThrowException.
   Dart_Handle retobj = Dart_Invoke(lib, Dart_NewString("testMain"), 0, NULL);
   EXPECT_VALID(retobj);
 
   // Throwing an exception here should result in an error.
   result = Dart_ThrowException(retobj);
   EXPECT(Dart_IsError(result));
 
-  // Now invoke method2 which invokes a natve method where it is
-  // ok to throw an exception, check the result which would indicate
-  // if an exception was thrown or not.
-  result = Dart_Invoke(retobj, Dart_NewString("method2"), 0, NULL);
+  // Now invoke 'test' which indirectly invokes a natve method where

[Bill Hesse, 2012/08/06 08:02:50]

native is misspelled natve.  Sentence is confusing.

// Call 'test' which calls the native function
// "ThrowException_native' (as 'thrower').
// Check that it throws an exception.

+  // it is ok to throw an exception, check the result which would
+  // indicate if an exception was thrown or not.
+  result = Dart_Invoke(retobj, Dart_NewString("test"), 0, NULL);
   EXPECT_VALID(result);
   EXPECT(Dart_IsInteger(result));
   int64_t value = 0;
   result = Dart_IntegerToInt64(result, &value);
   EXPECT_EQ(5, value);
 
   Dart_ExitScope();  // Exit the Dart API scope.
   EXPECT_EQ(size, state->ZoneSizeInBytes());
 }
 
@@ skipping 2522 matching lines @@
   EXPECT(Dart_IsString(str));
   len = -1;
   EXPECT_VALID(Dart_StringLength(str, &len));
   EXPECT_EQ(0, len);
 }
 
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart