Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: net/url_request/url_request_context_storage.h

Issue 10831277: [net] Change factory methods for HostResolver and HostCache to return a scoped_ptr (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_context_storage.h
diff --git a/net/url_request/url_request_context_storage.h b/net/url_request/url_request_context_storage.h
index f792d8ec2f6b892887311d782eaa4afaac2be9b6..bc040b2907d91c928dab15906db654d996dc3f48 100644
--- a/net/url_request/url_request_context_storage.h
+++ b/net/url_request/url_request_context_storage.h
@@ -41,10 +41,10 @@ class NET_EXPORT URLRequestContextStorage {
~URLRequestContextStorage();
// These setters will set both the member variables and call the setter on the
- // URLRequestContext object.
+ // URLRequestContext object. In all cases, ownership is passed to |this|.
void set_net_log(NetLog* net_log);
darin (slow to review) 2012/10/09 17:38:34 nit: all of these functions are incorrectly named
- void set_host_resolver(HostResolver* host_resolver);
+ void set_host_resolver(scoped_ptr<HostResolver> host_resolver);
void set_cert_verifier(CertVerifier* cert_verifier);
void set_server_bound_cert_service(
ServerBoundCertService* server_bound_cert_service);

Powered by Google App Engine
This is Rietveld 408576698