net/base/host_resolver_impl_unittest.cc - Issue 10831277: [net] Change factory methods for HostResolver and HostCache to return a scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/host_resolver_impl_unittest.cc

Issue 10831277: [net] Change factory methods for HostResolver and HostCache to return a scoped_ptr (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/host_resolver_impl_unittest.cc

diff --git a/net/base/host_resolver_impl_unittest.cc b/net/base/host_resolver_impl_unittest.cc

index 59d12f3c51a6487fb2159484c309741c2fd7c749..a949448f70303d27c81b59afa30bd6254b01a82d 100644

--- a/net/base/host_resolver_impl_unittest.cc

+++ b/net/base/host_resolver_impl_unittest.cc

@@ -758,7 +758,7 @@ TEST_F(HostResolverImplTest, StartWithinCallback) {

// Turn off caching for this host resolver.

resolver_.reset(new HostResolverImpl(

- NULL,

+ scoped_ptr<HostCache>(NULL),

darin (slow to review) 2012/10/09 17:38:34 nit: NULL parameter is unnecessary. just call the

szym 2012/10/09 21:40:43 Done.

DefaultLimits(),

DefaultParams(proc_),

scoped_ptr<DnsClient>(NULL),

darin (slow to review) 2012/10/09 17:38:34 same nit here

szym 2012/10/09 21:40:43 Done.

« net/base/host_resolver.cc ('K') | « net/base/host_resolver_impl.cc ('k') | net/base/mapped_host_resolver.h » ('j') | net/url_request/url_request_context_storage.h » ('J')