[net] Change factory methods for HostResolver and HostCache to return a scoped_ptr

net/url_request/url_request_context_storage.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_CONTEXT_STORAGE_H_
 #define NET_URL_REQUEST_URL_REQUEST_CONTEXT_STORAGE_H_
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 23 matching lines @@
 // member variables of URLRequestContext.
 class NET_EXPORT URLRequestContextStorage {
  public:
   // Note that URLRequestContextStorage does not acquire a reference to
   // URLRequestContext, since it is often designed to be embedded in a
   // URLRequestContext subclass.
   explicit URLRequestContextStorage(URLRequestContext* context);
   ~URLRequestContextStorage();
 
   // These setters will set both the member variables and call the setter on the
-  // URLRequestContext object.
+  // URLRequestContext object. In all cases, ownership is passed to |this|.
 
   void set_net_log(NetLog* net_log);

[darin (slow to review), 2012/10/09 17:38:34]

nit: all of these functions are incorrectly named using lower_case.  They should
be formatted as CamelCase since they are not implemented inline.  Obviously,
this is out of scope for this CL.  Just mentioning since I'm seeing it here.

-  void set_host_resolver(HostResolver* host_resolver);
+  void set_host_resolver(scoped_ptr<HostResolver> host_resolver);
   void set_cert_verifier(CertVerifier* cert_verifier);
   void set_server_bound_cert_service(
       ServerBoundCertService* server_bound_cert_service);
   void set_fraudulent_certificate_reporter(
       FraudulentCertificateReporter* fraudulent_certificate_reporter);
   void set_http_auth_handler_factory(
       HttpAuthHandlerFactory* http_auth_handler_factory);
   void set_proxy_service(ProxyService* proxy_service);
   void set_ssl_config_service(SSLConfigService* ssl_config_service);
   void set_network_delegate(NetworkDelegate* network_delegate);
@@ skipping 33 matching lines @@
   scoped_ptr<FtpTransactionFactory> ftp_transaction_factory_;
   scoped_ptr<URLRequestJobFactory> job_factory_;
   scoped_ptr<URLRequestThrottlerManager> throttler_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestContextStorage);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_CONTEXT_STORAGE_H_