[net] Change factory methods for HostResolver and HostCache to return a scoped_ptr

net/base/host_resolver_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/host_resolver_impl.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 740 matching lines @@
         // On completing the first request, start another request for "a".
         // Since caching is disabled, this will result in another async request.
         EXPECT_EQ(ERR_IO_PENDING, CreateRequest("a", 70)->Resolve());
       }
     }
   };
   set_handler(new MyHandler());
 
   // Turn off caching for this host resolver.
   resolver_.reset(new HostResolverImpl(
-      NULL,
+      scoped_ptr<HostCache>(NULL),

[darin (slow to review), 2012/10/09 17:38:34]

nit: NULL parameter is unnecessary.  just call the default ctor.

[szym, 2012/10/09 21:40:43]

Done.

       DefaultLimits(),
       DefaultParams(proc_),
       scoped_ptr<DnsClient>(NULL),

[darin (slow to review), 2012/10/09 17:38:34]

same nit here

[szym, 2012/10/09 21:40:43]

Done.

       NULL));
 
   for (size_t i = 0; i < 4; ++i) {
     EXPECT_EQ(ERR_IO_PENDING, CreateRequest("a", 80 + i)->Resolve()) << i;
   }
 
   proc_->SignalMultiple(2u);  // One for "a". One for the second "a".
 
   EXPECT_EQ(OK, requests_[0]->WaitForResult());
   ASSERT_EQ(5u, requests_.size());
@@ skipping 636 matching lines @@
   proc_->SignalMultiple(requests_.size());
 
   for (size_t i = 0; i < 2; ++i)
     EXPECT_EQ(ERR_NAME_NOT_RESOLVED, requests_[i]->WaitForResult()) << i;
 
   for (size_t i = 2; i < requests_.size(); ++i)
     EXPECT_EQ(OK, requests_[i]->WaitForResult()) << i;
 }
 
 }  // namespace net