Fixed check return warnings from Coverity.

chrome/browser/policy/policy_loader_win.cc

Index: chrome/browser/policy/policy_loader_win.cc
diff --git a/chrome/browser/policy/policy_loader_win.cc b/chrome/browser/policy/policy_loader_win.cc
index 36a44fea38450e53e1a55832ad4f4d7e2a503c2f..17be5d2902efb2a29f914e5c5b9b149bf5083fd8 100644
--- a/chrome/browser/policy/policy_loader_win.cc
+++ b/chrome/browser/policy/policy_loader_win.cc
@@ -88,7 +88,8 @@ bool LoadHighestPriorityKey(const string16& key_path,
       string16 path(kKeyPaths[k].path);
       if (!key_path.empty())
         path += kPathSep + key_path;
-      key->Open(kHives[h].hive, path.c_str(), KEY_READ);
+      LONG rc = key->Open(kHives[h].hive, path.c_str(), KEY_READ);
+      DCHECK_EQ(rc, ERROR_SUCCESS);

[Mattias Nissler (ping if slow), 2012/07/26 09:37:06]

I think this is also wrong. Keys may not exist, so it's perfectly fine for this
to fail (and we shouldn't DCHECK). That's why we have the key->Valid() check
below.

[Joao da Silva, 2012/07/26 10:04:33]

Yep. Rewrite as:

if (key->Open(...) != ERROR_SUCCESS || !key->Valid())
  continue;

[Danh Nguyen, 2012/07/26 15:46:27]

Fixed per Joao's advice.  Thanks.

       if (!key->Valid())
         continue;
       if (value_name.empty() || key->HasValue(value_name.c_str())) {