Fixed check return warnings from Coverity.

chrome/browser/value_store/testing_value_store.cc

Index: chrome/browser/value_store/testing_value_store.cc
diff --git a/chrome/browser/value_store/testing_value_store.cc b/chrome/browser/value_store/testing_value_store.cc
index f5dbcb116ce9e40d3b593106b59cc313e8dd5da7..a54c6c455f58d8084ff6878ba1870b350c0b78de 100644
--- a/chrome/browser/value_store/testing_value_store.cc
+++ b/chrome/browser/value_store/testing_value_store.cc
@@ -98,7 +98,8 @@ ValueStore::WriteResult TestingValueStore::Set(
   scoped_ptr<ValueStoreChangeList> changes(new ValueStoreChangeList());
   for (DictionaryValue::Iterator it(settings); it.HasNext(); it.Advance()) {
     Value* old_value = NULL;
-    storage_.GetWithoutPathExpansion(it.key(), &old_value);
+    bool rv = storage_.GetWithoutPathExpansion(it.key(), &old_value);
+    DCHECK(rv);

[Mattias Nissler (ping if slow), 2012/07/26 09:37:06]

Same thing, this may return false, in which case old_value is NULL, which is
handled properly in line 103.

     if (!old_value || !old_value->Equals(&it.value())) {

[Joao da Silva, 2012/07/26 10:04:33]

As Mattias mentioned, the DCHECK is wrong. Maybe rewrite this as:

if (!storage_.GetWithoutPathExpansion(it.key(), &old_value) ||
old_value->Equals(...)) { ... }

[Danh Nguyen, 2012/07/26 15:46:27]

Fixed.  Thanks Joao for your suggestion.

       changes->push_back(
           ValueStoreChange(