Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2031)

Unified Diff: chrome/browser/policy/managed_mode_policy_provider.cc

Issue 10830022: Fixed check return warnings from Coverity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/managed_mode_policy_provider.cc
diff --git a/chrome/browser/policy/managed_mode_policy_provider.cc b/chrome/browser/policy/managed_mode_policy_provider.cc
index e0521679330073a464e82842617f1a545d0c482a..97570c68e2101a71b235ce56a3e9db9896e82428 100644
--- a/chrome/browser/policy/managed_mode_policy_provider.cc
+++ b/chrome/browser/policy/managed_mode_policy_provider.cc
@@ -43,7 +43,8 @@ const base::Value* ManagedModePolicyProvider::GetPolicy(
const std::string& key) const {
base::DictionaryValue* dict = GetCachedPolicy();
base::Value* value = NULL;
- dict->GetWithoutPathExpansion(key, &value);
+ bool rv = dict->GetWithoutPathExpansion(key, &value);
+ DCHECK(rv);
Mattias Nissler (ping if slow) 2012/07/26 09:37:06 I think this is wrong, the intention here is to re
Danh Nguyen 2012/07/26 15:46:27 Reverted. I'll remove the DCHECK and add a note he
return value;
}
« no previous file with comments | « no previous file | chrome/browser/policy/policy_loader_win.cc » ('j') | chrome/browser/policy/policy_loader_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698