Implement NavigationControllerWebView.PostURL

content/public/browser/navigation_entry.h

Index: content/public/browser/navigation_entry.h
diff --git a/content/public/browser/navigation_entry.h b/content/public/browser/navigation_entry.h
index ddbc1d0214c7d99d395c8006eb09f85088588ac0..1ec79866d44e4dd654ee4475837b548415ebb24e 100644
--- a/content/public/browser/navigation_entry.h
+++ b/content/public/browser/navigation_entry.h
@@ -6,7 +6,9 @@
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_
 
 #include <string>
+#include <vector>

[joth, 2012/07/30 19:10:18]

again not needed

[boliu, 2012/07/30 21:53:45]

Done.

 
+#include "base/memory/ref_counted_memory.h"
 #include "base/string16.h"
 #include "content/common/content_export.h"
 #include "content/public/common/page_transition_types.h"
@@ -125,8 +127,10 @@ class NavigationEntry {
   // have to be reposted to reload the page properly. This flag indicates
   // whether the page had post data.
   //
-  // The actual post data is stored in the content_state and is extracted by
-  // WebKit to actually make the request.
+  // The actual post data is stored either in
+  // 1) browser_initiated_post_data when a new post data request is started.
+  // 2) content_state when a post request has started and is extracted by
+  //    WebKit to actually make the request.
   virtual void SetHasPostData(bool has_post_data) = 0;
   virtual bool GetHasPostData() const = 0;
 
@@ -134,6 +138,15 @@ class NavigationEntry {
   virtual void SetPostID(int64 post_id) = 0;
   virtual int64 GetPostID() const = 0;
 
+  // Holds the raw post data of a browser initiated post request.
+  // For efficiency, this should be cleared when content_state is populated
+  // since the data is duplicated. Note this is not persisted in session
+  // restore and it is shallow copied with the copy Create above.
+  virtual void SetBrowserInitiatedPostData(
+      scoped_refptr<base::RefCountedBytes> data) = 0;
+  virtual const scoped_refptr<base::RefCountedBytes>
+      GetBrowserInitiatedPostData() const = 0;

[joth, 2012/07/30 19:10:18]

input is raw pointer of const&

return type raw pointer or return the scoped_ptr by value, but non-const.


ah here we are
https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thr...

yes raw pointers seemed generally preferred.

[boliu, 2012/07/30 21:53:45]

Using const* instead of const& for Set so it is possible to pass in NULL.

Switch to scoped_refptr<const base::RefCountedMemory> for Get. scoped_refptr is
used because this value is very short lived and returning a raw pointer seems a
bit dangerous. The added const is necessary due to the const in the Set method.
RefCountedMemory only provides const public methods so this is okay.

+
   // The favicon data and tracking information. See content::FaviconStatus.
   virtual const FaviconStatus& GetFavicon() const = 0;
   virtual FaviconStatus& GetFavicon() = 0;