Implement NavigationControllerWebView.PostURL

content/public/browser/navigation_entry.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_
 
 #include <string>
+#include <vector>

[joth, 2012/07/30 19:10:18]

again not needed

[boliu, 2012/07/30 21:53:45]

Done.

 
+#include "base/memory/ref_counted_memory.h"
 #include "base/string16.h"
 #include "content/common/content_export.h"
 #include "content/public/common/page_transition_types.h"
 #include "content/public/common/page_type.h"
 #include "content/public/common/referrer.h"
 
 class GURL;
 
 namespace content {
 
@@ skipping 98 matching lines @@
   // the name that the user things of the site as having.
   //
   // This URL will be is_empty() if the URL was navigated to some other way.
   // Callers should fall back on using the regular or display URL in this case.
   virtual const GURL& GetUserTypedURL() const = 0;
 
   // Post data is form data that was posted to get to this page. The data will
   // have to be reposted to reload the page properly. This flag indicates
   // whether the page had post data.
   //
-  // The actual post data is stored in the content_state and is extracted by
-  // WebKit to actually make the request.
+  // The actual post data is stored either in
+  // 1) browser_initiated_post_data when a new post data request is started.
+  // 2) content_state when a post request has started and is extracted by
+  //    WebKit to actually make the request.
   virtual void SetHasPostData(bool has_post_data) = 0;
   virtual bool GetHasPostData() const = 0;
 
   // The Post identifier associated with the page.
   virtual void SetPostID(int64 post_id) = 0;
   virtual int64 GetPostID() const = 0;
 
+  // Holds the raw post data of a browser initiated post request.
+  // For efficiency, this should be cleared when content_state is populated
+  // since the data is duplicated. Note this is not persisted in session
+  // restore and it is shallow copied with the copy Create above.
+  virtual void SetBrowserInitiatedPostData(
+      scoped_refptr<base::RefCountedBytes> data) = 0;
+  virtual const scoped_refptr<base::RefCountedBytes>
+      GetBrowserInitiatedPostData() const = 0;

[joth, 2012/07/30 19:10:18]

input is raw pointer of const&

return type raw pointer or return the scoped_ptr by value, but non-const.


ah here we are
https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thr...

yes raw pointers seemed generally preferred.

[boliu, 2012/07/30 21:53:45]

Using const* instead of const& for Set so it is possible to pass in NULL.

Switch to scoped_refptr<const base::RefCountedMemory> for Get. scoped_refptr is
used because this value is very short lived and returning a raw pointer seems a
bit dangerous. The added const is necessary due to the const in the Set method.
RefCountedMemory only provides const public methods so this is okay.

+
   // The favicon data and tracking information. See content::FaviconStatus.
   virtual const FaviconStatus& GetFavicon() const = 0;
   virtual FaviconStatus& GetFavicon() = 0;
 
   // All the SSL flags and state. See content::SSLStatus.
   virtual const SSLStatus& GetSSL() const = 0;
   virtual SSLStatus& GetSSL() = 0;
 
   // Store the URL that caused this NavigationEntry to be created.
   virtual void SetOriginalRequestURL(const GURL& original_url) = 0;
   virtual const GURL& GetOriginalRequestURL() const = 0;
 
   // Store whether or not we're overriding the user agent.
   virtual void SetIsOverridingUserAgent(bool override) = 0;
   virtual bool GetIsOverridingUserAgent() const = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_ENTRY_H_