Implement NavigationControllerWebView.PostURL

content/public/browser/android/navigation_controller_webview.h

Index: content/public/browser/android/navigation_controller_webview.h
diff --git a/content/public/browser/android/navigation_controller_webview.h b/content/public/browser/android/navigation_controller_webview.h
index 79c784dcd7a2947faeeae7f104374eccae27aba9..7692d2523d0efd4fda06205490a5febfdc14f2bc 100644
--- a/content/public/browser/android/navigation_controller_webview.h
+++ b/content/public/browser/android/navigation_controller_webview.h
@@ -5,6 +5,10 @@
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_WEBVIEW_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_WEBVIEW_H_
 
+#include <vector>

[joth, 2012/07/30 19:10:18]

not needed

[boliu, 2012/07/30 21:53:45]

Done.

+
+#include "base/memory/ref_counted_memory.h"
+
 class GURL;
 
 namespace content {
@@ -27,6 +31,12 @@ class NavigationControllerWebView {
                                    const GURL& base_url,
                                    const GURL& history_url,
                                    bool is_overriding_user_agent) = 0;
+
+  // Used to directly send a http post request with a raw http body provided.
+  virtual void PostURL(const GURL& url,
+                       const content::Referrer& referrer,
+                       const scoped_refptr<base::RefCountedBytes> http_body,

[joth, 2012/07/30 19:10:18]

if we want to use refcountedXxx at all, it should be RefCountedMemory. Otherwise
it gives the client not extra flexibility over just passing a vector.

I think* the preferred style is to pass the naked pointer (RefCountedMemory*
http_body) or if a scoped_ptr<> is specified, it should be a const reference .

(* there was a long debate on the maillist last year, no strong consensus
reached IIRC)

[boliu, 2012/07/30 21:53:45]

Switch to const& here since it's an input as per the discussion thread.

+                       bool is_overriding_user_agent) = 0;
 };
 
 }  // namespace content