Implement NavigationControllerWebView.PostURL

content/public/browser/android/navigation_controller_webview.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_WEBVIEW_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_WEBVIEW_H_
 
+#include <vector>

[joth, 2012/07/30 19:10:18]

not needed

[boliu, 2012/07/30 21:53:45]

Done.

+
+#include "base/memory/ref_counted_memory.h"
+
 class GURL;
 
 namespace content {
 
 struct Referrer;
 
 // An addition to NavigationController with methods required to implement
 // Android WebView.
 //
 // For the details, please consult the Android developer reference of
 // the WebView API:
 // http://developer.android.com/reference/android/webkit/WebView.html
 class NavigationControllerWebView {
  public:
   // Loads a 'data:' scheme URL with specified base URL and a history entry URL.
   // This is only safe to be used for browser-initiated data: URL navigations,
   // since it shows arbitrary content as if it comes from |history_url|.
   virtual void LoadDataWithBaseURL(const GURL& data_url,
                                    const Referrer& referrer,
                                    const GURL& base_url,
                                    const GURL& history_url,
                                    bool is_overriding_user_agent) = 0;
+
+  // Used to directly send a http post request with a raw http body provided.
+  virtual void PostURL(const GURL& url,
+                       const content::Referrer& referrer,
+                       const scoped_refptr<base::RefCountedBytes> http_body,

[joth, 2012/07/30 19:10:18]

if we want to use refcountedXxx at all, it should be RefCountedMemory. Otherwise
it gives the client not extra flexibility over just passing a vector.

I think* the preferred style is to pass the naked pointer (RefCountedMemory*
http_body) or if a scoped_ptr<> is specified, it should be a const reference .

(* there was a long debate on the maillist last year, no strong consensus
reached IIRC)

[boliu, 2012/07/30 21:53:45]

Switch to const& here since it's an input as per the discussion thread.

+                       bool is_overriding_user_agent) = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_WEBVIEW_H_