runtime/vm/compiler.cc - Issue 10827139: Fix a register allocation crash on IA32, caused by an uninitialized finger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 10827139: Fix a register allocation crash on IA32, caused by an uninitialized finger. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler.cc

diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc

index d0f17129abc0251f3bb6cba29f9702fe6ccb4e56..d14d3c035cdf60072b71fd4958c14c9e759e01b6 100644

--- a/runtime/vm/compiler.cc

+++ b/runtime/vm/compiler.cc

@@ -35,7 +35,7 @@ DEFINE_FLAG(bool, trace_compiler, false, "Trace compiler operations.");

#if defined(TARGET_ARCH_X64)

DEFINE_FLAG(bool, use_ssa, true, "Use SSA form");

#else

-DEFINE_FLAG(bool, use_ssa, false, "Use SSA form");

+DEFINE_FLAG(bool, use_ssa, true, "Use SSA form");

Kevin Millikin (Google) 2012/08/02 13:38:22 I won't commit this :)

Vyacheslav Egorov (Google) 2012/08/02 13:38:56 don't forget to remove this

#endif

DEFINE_FLAG(int, deoptimization_counter_threshold, 5,

"How many times we allow deoptimization before we disallow"

« no previous file with comments | « no previous file | runtime/vm/flow_graph_allocator.cc » ('j') | runtime/vm/flow_graph_allocator.cc » ('J')