Issue 10827139: Fix a register allocation crash on IA32, caused by an uninitialized finger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827139: Fix a register allocation crash on IA32, caused by an uninitialized finger. (Closed)

Created:
8 years, 4 months ago by Kevin Millikin (Google)

Modified:
8 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a register allocation crash on IA32, caused by an uninitialized finger. R=vegorov@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10166

Patch Set 1 #

Total comments: 3

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	runtime/vm/compiler.cc	View		1 chunk	+1 line, -1 line	2 comments	Download
	M	runtime/vm/flow_graph_allocator.cc	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

http://codereview.chromium.org/10827139/diff/1/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): http://codereview.chromium.org/10827139/diff/1/runtime/vm/compiler.cc#newcode38 runtime/vm/compiler.cc:38: DEFINE_FLAG(bool, use_ssa, true, "Use SSA form"); I won't commit ...

8 years, 4 months ago (2012-08-02 13:38:22 UTC) #2

Vyacheslav Egorov (Google)

8 years, 4 months ago (2012-08-02 13:38:56 UTC) #3

LGTM

https://chromiumcodereview.appspot.com/10827139/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://chromiumcodereview.appspot.com/10827139/diff/1/runtime/vm/compiler.cc...
runtime/vm/compiler.cc:38: DEFINE_FLAG(bool, use_ssa, true, "Use SSA form");
don't forget to remove this

https://chromiumcodereview.appspot.com/10827139/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_allocator.cc (right):

https://chromiumcodereview.appspot.com/10827139/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_allocator.cc:1067: if (interval == NULL) {
We should consider initializing finger eagerly.

Expand Messages | Collapse Messages