runtime/vm/flow_graph_allocator.cc - Issue 10827139: Fix a register allocation crash on IA32, caused by an uninitialized finger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_allocator.cc

Issue 10827139: Fix a register allocation crash on IA32, caused by an uninitialized finger. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_allocator.cc

diff --git a/runtime/vm/flow_graph_allocator.cc b/runtime/vm/flow_graph_allocator.cc

index aa1b9416fd291947fc9bd2063541b92e5fe46270..36a9306eca9db9ff41e9b87371aef4ffdee28e13 100644

--- a/runtime/vm/flow_graph_allocator.cc

+++ b/runtime/vm/flow_graph_allocator.cc

@@ -1064,6 +1064,11 @@ LiveRange* LiveRange::SplitAt(intptr_t split_pos) {

if (Start() == split_pos) return this;

UseInterval* interval = finger_.first_pending_use_interval();

+ if (interval == NULL) {

Vyacheslav Egorov (Google) 2012/08/02 13:38:56 We should consider initializing finger eagerly.

+ finger_.Initialize(this);

+ interval = finger_.first_pending_use_interval();

+ }

ASSERT(interval->start() < split_pos);

ASSERT(split_pos < End());

« runtime/vm/compiler.cc ('K') | « runtime/vm/compiler.cc ('k') | no next file » | no next file with comments »