Check for warnings when loading extensions in browser tests.

chrome/browser/extensions/api/web_request/web_request_apitest.cc

Index: chrome/browser/extensions/api/web_request/web_request_apitest.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc
index 55220b91a4dc973426a240b4ebfc8ecab6f85be2..bcc4d5dfe81292ca0e4908908b2438da25a5650e 100644
--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc
@@ -156,11 +156,14 @@ void ExtensionWebRequestApiTest::RunPermissionTest(
   ExtensionTestMessageListener listener("done", true);
   ExtensionTestMessageListener listener_incognito("done_incognito", true);
 
-  ASSERT_TRUE(LoadExtensionWithOptions(
+  int load_extension_flags = kFlagNone;

[miket_OOO, 2012/08/06 22:33:28]

To be hyper-correct, this is a ExtensionApiTest::Flags, not an int. But I see
lots and lots of existing int usage, so it's OK as-is.

[Mihai Parparita -not on Chrome, 2012/08/09 23:04:08]

ExtensionApiTest::Flags isn't really the right type, because once we start to or
things together, the resulting value is no longer a valid enum value.

+  if (load_extension_with_incognito_permission) {

[Aaron Boodman, 2012/08/07 02:12:35]

Either way is allowed, but we tend to drop the braces in this case in extensions
code.

[Mihai Parparita -not on Chrome, 2012/08/09 23:04:08]

Done.

+    load_extension_flags |= kFlagEnableIncognito;
+  }
+  ASSERT_TRUE(LoadExtensionWithFlags(
       test_data_dir_.AppendASCII("webrequest_permissions")
                     .AppendASCII(extension_directory),
-      load_extension_with_incognito_permission,
-      false));
+      load_extension_flags));
 
   // Test that navigation in regular window is properly redirected.
   EXPECT_TRUE(listener.WaitUntilSatisfied());