Check for warnings when loading extensions in browser tests.

chrome/browser/extensions/api/web_request/web_request_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "chrome/browser/extensions/api/web_request/web_request_api.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 138 matching lines @@
     const char* exptected_content_incognito_window) {
   ResultCatcher catcher;
   catcher.RestrictToProfile(browser()->profile());
   ResultCatcher catcher_incognito;
   catcher_incognito.RestrictToProfile(
       browser()->profile()->GetOffTheRecordProfile());
 
   ExtensionTestMessageListener listener("done", true);
   ExtensionTestMessageListener listener_incognito("done_incognito", true);
 
-  ASSERT_TRUE(LoadExtensionWithOptions(
+  int load_extension_flags = kFlagNone;

[miket_OOO, 2012/08/06 22:33:28]

To be hyper-correct, this is a ExtensionApiTest::Flags, not an int. But I see
lots and lots of existing int usage, so it's OK as-is.

[Mihai Parparita -not on Chrome, 2012/08/09 23:04:08]

ExtensionApiTest::Flags isn't really the right type, because once we start to or
things together, the resulting value is no longer a valid enum value.

+  if (load_extension_with_incognito_permission) {

[Aaron Boodman, 2012/08/07 02:12:35]

Either way is allowed, but we tend to drop the braces in this case in extensions
code.

[Mihai Parparita -not on Chrome, 2012/08/09 23:04:08]

Done.

+    load_extension_flags |= kFlagEnableIncognito;
+  }
+  ASSERT_TRUE(LoadExtensionWithFlags(
       test_data_dir_.AppendASCII("webrequest_permissions")
                     .AppendASCII(extension_directory),
-      load_extension_with_incognito_permission,
-      false));
+      load_extension_flags));
 
   // Test that navigation in regular window is properly redirected.
   EXPECT_TRUE(listener.WaitUntilSatisfied());
 
   // This navigation should be redirected.
   ui_test_utils::NavigateToURL(
       browser(),
       test_server()->GetURL("files/extensions/test_file.html"));
 
   std::string body;
@@ skipping 44 matching lines @@
   // Test split with incognito permission.
   RunPermissionTest("split", true, true, "redirected1", "redirected2");
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest,
                        WebRequestDeclarativePermissionSplit2) {
   // Test split without incognito permission.
   RunPermissionTest("split", false, false, "redirected1", "");
 }