chrome/browser/extensions/api/extension_action/page_action_apitest.cc - Issue 10826157: Check for warnings when loading extensions in browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/page_action_apitest.cc

Issue 10826157: Check for warnings when loading extensions in browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix existing tests Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_request/web_request_apitest.cc » ('j') | chrome/browser/extensions/api/web_request/web_request_apitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/page_action_apitest.cc

diff --git a/chrome/browser/extensions/api/extension_action/page_action_apitest.cc b/chrome/browser/extensions/api/extension_action/page_action_apitest.cc

index 1b7d599000f9afa22ff599f4689c078df8a36039..b6f1cc6ed2d084e3a698d4fc17a5007f5d64a3dc 100644

--- a/chrome/browser/extensions/api/extension_action/page_action_apitest.cc

+++ b/chrome/browser/extensions/api/extension_action/page_action_apitest.cc

@@ -145,7 +145,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PageActionRemovePopup) {

// Tests old-style pageActions API that is deprecated but we don't want to

// break.

IN_PROC_BROWSER_TEST_F(ExtensionApiTest, OldPageActions) {

- ASSERT_TRUE(RunExtensionTest("page_action/old_api")) << message_;

+ ASSERT_TRUE(RunExtensionTestIgnoreManifestWarnings("page_action/old_api")) <<

+ message_;

const Extension* extension = GetSingleLoadedExtension();

ASSERT_TRUE(extension) << message_;