Issue 10823303: add unit tests for MediaGalleriesDialogGtk

Issue 10823303: add unit tests for MediaGalleriesDialogGtk (Closed)

Created:
8 years, 4 months ago by Evan Stade

Modified:
8 years, 4 months ago

Reviewers:
sail, sky

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

add unit tests for MediaGalleriesDialogGtk BUG=134929 TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151564

Patch Set 3 : review #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+139 lines, -19 lines)			Patch
M	chrome/browser/media_gallery/media_galleries_dialog_controller.h	View		4 chunks	+15 lines, -9 lines	0 comments	Download
M	chrome/browser/media_gallery/media_galleries_dialog_controller.cc	View		4 chunks	+14 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download
A	chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc	View	1 2	1 chunk	+97 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sail

LGTM http://codereview.chromium.org/10823303/diff/3002/chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc File chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc (right): http://codereview.chromium.org/10823303/diff/3002/chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc#newcode21 chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc:21: return MediaGalleriesDialogController::GalleryToggled(pref_info, enabled); no need for return http://codereview.chromium.org/10823303/diff/3002/chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc#newcode28 ...

8 years, 4 months ago (2012-08-14 21:00:33 UTC) #2

Evan Stade

http://codereview.chromium.org/10823303/diff/3002/chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc File chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc (right): http://codereview.chromium.org/10823303/diff/3002/chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc#newcode21 chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc:21: return MediaGalleriesDialogController::GalleryToggled(pref_info, enabled); On 2012/08/14 21:00:33, sail wrote: > ...

8 years, 4 months ago (2012-08-14 21:15:52 UTC) #3

chrome_tests.gypi change TBR'd to Scott.

Expand Messages | Collapse Messages