Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.cc

Issue 10823303: add unit tests for MediaGalleriesDialogGtk (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.cc
diff --git a/chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.cc b/chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.cc
index 108bed196dd50cc55ac92646ed0e421125cf91f5..16fbec63a6b0f3a17daeda5022787bce7c689cdb 100644
--- a/chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.cc
+++ b/chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.cc
@@ -26,7 +26,10 @@ MediaGalleriesDialogGtk::MediaGalleriesDialogGtk(
ignore_toggles_(false),
accepted_(false) {
InitWidgets();
- window_ = new ConstrainedWindowGtk(controller->tab_contents(), this);
+
+ // May be NULL during tests.
+ if (controller->tab_contents())
+ window_ = new ConstrainedWindowGtk(controller->tab_contents(), this);
}
MediaGalleriesDialogGtk::~MediaGalleriesDialogGtk() {
@@ -124,7 +127,8 @@ void MediaGalleriesDialogGtk::DeleteDelegate() {
}
void MediaGalleriesDialogGtk::OnToggled(GtkWidget* widget) {
- gtk_widget_set_sensitive(confirm_, TRUE);
+ if (confirm_)
+ gtk_widget_set_sensitive(confirm_, TRUE);
if (ignore_toggles_)
return;

Powered by Google App Engine
This is Rietveld 408576698