Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Side by Side Diff: chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.cc

Issue 10823303: add unit tests for MediaGalleriesDialogGtk (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.h" 5 #include "chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/browser/media_gallery/media_galleries_preferences.h" 9 #include "chrome/browser/media_gallery/media_galleries_preferences.h"
10 #include "chrome/browser/ui/gtk/gtk_util.h" 10 #include "chrome/browser/ui/gtk/gtk_util.h"
11 #include "grit/generated_resources.h" 11 #include "grit/generated_resources.h"
12 #include "ui/base/gtk/gtk_hig_constants.h" 12 #include "ui/base/gtk/gtk_hig_constants.h"
13 #include "ui/base/l10n/l10n_util.h" 13 #include "ui/base/l10n/l10n_util.h"
14 14
15 namespace chrome { 15 namespace chrome {
16 16
17 typedef MediaGalleriesDialogController::KnownGalleryPermissions 17 typedef MediaGalleriesDialogController::KnownGalleryPermissions
18 GalleryPermissions; 18 GalleryPermissions;
19 19
20 MediaGalleriesDialogGtk::MediaGalleriesDialogGtk( 20 MediaGalleriesDialogGtk::MediaGalleriesDialogGtk(
21 MediaGalleriesDialogController* controller) 21 MediaGalleriesDialogController* controller)
22 : controller_(controller), 22 : controller_(controller),
23 window_(NULL), 23 window_(NULL),
24 confirm_(NULL), 24 confirm_(NULL),
25 checkbox_container_(NULL), 25 checkbox_container_(NULL),
26 ignore_toggles_(false), 26 ignore_toggles_(false),
27 accepted_(false) { 27 accepted_(false) {
28 InitWidgets(); 28 InitWidgets();
29 window_ = new ConstrainedWindowGtk(controller->tab_contents(), this); 29
30 // May be NULL during tests.
31 if (controller->tab_contents())
32 window_ = new ConstrainedWindowGtk(controller->tab_contents(), this);
30 } 33 }
31 34
32 MediaGalleriesDialogGtk::~MediaGalleriesDialogGtk() { 35 MediaGalleriesDialogGtk::~MediaGalleriesDialogGtk() {
33 } 36 }
34 37
35 void MediaGalleriesDialogGtk::InitWidgets() { 38 void MediaGalleriesDialogGtk::InitWidgets() {
36 contents_.Own(gtk_vbox_new(FALSE, ui::kContentAreaSpacing)); 39 contents_.Own(gtk_vbox_new(FALSE, ui::kContentAreaSpacing));
37 40
38 GtkWidget* header = 41 GtkWidget* header =
39 gtk_util::CreateBoldLabel(UTF16ToUTF8(controller_->GetHeader())); 42 gtk_util::CreateBoldLabel(UTF16ToUTF8(controller_->GetHeader()));
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 120
118 GtkWidget* MediaGalleriesDialogGtk::GetFocusWidget() { 121 GtkWidget* MediaGalleriesDialogGtk::GetFocusWidget() {
119 return confirm_; 122 return confirm_;
120 } 123 }
121 124
122 void MediaGalleriesDialogGtk::DeleteDelegate() { 125 void MediaGalleriesDialogGtk::DeleteDelegate() {
123 controller_->DialogFinished(accepted_); 126 controller_->DialogFinished(accepted_);
124 } 127 }
125 128
126 void MediaGalleriesDialogGtk::OnToggled(GtkWidget* widget) { 129 void MediaGalleriesDialogGtk::OnToggled(GtkWidget* widget) {
127 gtk_widget_set_sensitive(confirm_, TRUE); 130 if (confirm_)
131 gtk_widget_set_sensitive(confirm_, TRUE);
128 132
129 if (ignore_toggles_) 133 if (ignore_toggles_)
130 return; 134 return;
131 135
132 for (CheckboxMap::iterator iter = checkbox_map_.begin(); 136 for (CheckboxMap::iterator iter = checkbox_map_.begin();
133 iter != checkbox_map_.end(); ++iter) { 137 iter != checkbox_map_.end(); ++iter) {
134 if (iter->second == widget) { 138 if (iter->second == widget) {
135 controller_->GalleryToggled( 139 controller_->GalleryToggled(
136 iter->first, gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(widget))); 140 iter->first, gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(widget)));
137 return; 141 return;
(...skipping 19 matching lines...) Expand all
157 161
158 // MediaGalleriesDialogController ---------------------------------------------- 162 // MediaGalleriesDialogController ----------------------------------------------
159 163
160 // static 164 // static
161 MediaGalleriesDialog* MediaGalleriesDialog::Create( 165 MediaGalleriesDialog* MediaGalleriesDialog::Create(
162 MediaGalleriesDialogController* controller) { 166 MediaGalleriesDialogController* controller) {
163 return new MediaGalleriesDialogGtk(controller); 167 return new MediaGalleriesDialogGtk(controller);
164 } 168 }
165 169
166 } // namespace chrome 170 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698