Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 10823233: Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments addressed (AsDevToolsWindow() is necessary, since the DevToolsWindow* result is used in te… Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index bab1509dd9e8cf4e2cde7cabe829316a9ea90433..40b6f8145ca3bc9f1010b1e5ad649fb9cb6e3e4a 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -508,7 +508,7 @@ void BrowserCommandController::ExecuteCommandWithDisposition(
CreateApplicationShortcuts(browser_);
break;
case IDC_DEV_TOOLS:
- ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_NONE);
+ ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_SHOW);
break;
case IDC_DEV_TOOLS_CONSOLE:
ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE);
@@ -516,6 +516,9 @@ void BrowserCommandController::ExecuteCommandWithDisposition(
case IDC_DEV_TOOLS_INSPECT:
ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_INSPECT);
break;
+ case IDC_DEV_TOOLS_TOGGLE_INSPECTOR:
+ ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_TOGGLE);
+ break;
case IDC_TASK_MANAGER:
OpenTaskManager(browser_, false);
break;
@@ -952,6 +955,8 @@ void BrowserCommandController::UpdateCommandsForDevTools() {
dev_tools_enabled);
command_updater_.UpdateCommandEnabled(IDC_DEV_TOOLS_INSPECT,
dev_tools_enabled);
+ command_updater_.UpdateCommandEnabled(IDC_DEV_TOOLS_TOGGLE_INSPECTOR,
pfeldman 2012/08/24 10:16:14 _TOGGLE ? (Drop INSPECTOR)
apavlov 2012/08/24 11:02:13 Done.
+ dev_tools_enabled);
}
void BrowserCommandController::UpdateCommandsForBookmarkEditing() {

Powered by Google App Engine
This is Rietveld 408576698