chrome/browser/ui/browser_commands.cc - Issue 10823233: Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 10823233: Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments addressed (AsDevToolsWindow() is necessary, since the DevToolsWindow* result is used in te… Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_command_controller.cc ('K') | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/gtk/accelerators_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_commands.cc

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc

index a4c589dea2f6014a849bc9ff5cf9cd7d94714f00..047cf7fee16cad3d9cd5e59c259ad786ba99a286 100644

--- a/chrome/browser/ui/browser_commands.cc

+++ b/chrome/browser/ui/browser_commands.cc

@@ -803,10 +803,7 @@ void ToggleDevToolsWindow(Browser* browser, DevToolsToggleAction action) {

content::RecordAction(UserMetricsAction("DevTools_ToggleConsole"));

else

content::RecordAction(UserMetricsAction("DevTools_ToggleWindow"));

- DevToolsWindow::ToggleDevToolsWindow(

- GetActiveWebContents(browser)->GetRenderViewHost(),

- action);

+ DevToolsWindow::ToggleDevToolsWindow(browser, action);

}

bool CanOpenTaskManager() {