Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress

chrome/browser/ui/browser_command_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_command_controller.h"
 
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/defaults.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 490 matching lines @@
       break;
 
     // Show various bits of UI
     case IDC_OPEN_FILE:
       browser_->OpenFile();
       break;
     case IDC_CREATE_SHORTCUTS:
       CreateApplicationShortcuts(browser_);
       break;
     case IDC_DEV_TOOLS:
-      ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_NONE);
+      ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_SHOW);
       break;
     case IDC_DEV_TOOLS_CONSOLE:
       ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_SHOW_CONSOLE);
       break;
     case IDC_DEV_TOOLS_INSPECT:
       ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_INSPECT);
       break;
+    case IDC_DEV_TOOLS_TOGGLE_INSPECTOR:
+      ToggleDevToolsWindow(browser_, DEVTOOLS_TOGGLE_ACTION_TOGGLE);
+      break;
     case IDC_TASK_MANAGER:
       OpenTaskManager(browser_, false);
       break;
     case IDC_VIEW_BACKGROUND_PAGES:
       OpenTaskManager(browser_, true);
       break;
     case IDC_FEEDBACK:
       OpenFeedbackDialog(browser_);
       break;
 
@@ skipping 416 matching lines @@
 
 void BrowserCommandController::UpdateCommandsForDevTools() {
   bool dev_tools_enabled =
       !profile()->GetPrefs()->GetBoolean(prefs::kDevToolsDisabled);
   command_updater_.UpdateCommandEnabled(IDC_DEV_TOOLS,
                                         dev_tools_enabled);
   command_updater_.UpdateCommandEnabled(IDC_DEV_TOOLS_CONSOLE,
                                         dev_tools_enabled);
   command_updater_.UpdateCommandEnabled(IDC_DEV_TOOLS_INSPECT,
                                         dev_tools_enabled);
+  command_updater_.UpdateCommandEnabled(IDC_DEV_TOOLS_TOGGLE_INSPECTOR,

[pfeldman, 2012/08/24 10:16:14]

_TOGGLE ? (Drop INSPECTOR)

[apavlov, 2012/08/24 11:02:13]

Done.

+                                        dev_tools_enabled);
 }
 
 void BrowserCommandController::UpdateCommandsForBookmarkEditing() {
   command_updater_.UpdateCommandEnabled(IDC_BOOKMARK_PAGE,
                                         CanBookmarkCurrentPage(browser_));
   command_updater_.UpdateCommandEnabled(IDC_BOOKMARK_ALL_TABS,
                                         CanBookmarkAllTabs(browser_));
   command_updater_.UpdateCommandEnabled(IDC_PIN_TO_START_SCREEN,
                                         true);
 }
@@ skipping 139 matching lines @@
 bool BrowserCommandController::IsFullScreenWindowOpen() {
 #if defined(USE_ASH)
   aura::Window* window = ash::wm::GetActiveWindow();
   return (window && ash::wm::IsWindowFullscreen(window));
 #else
   return false;
 #endif
 }
 
 }  // namespace chrome